Skip to content

Commit 711c617

Browse files
Moved Event back to Observation
1 parent edfae1d commit 711c617

File tree

5 files changed

+13
-11
lines changed

5 files changed

+13
-11
lines changed

micrometer-docs-generator-commons/src/main/java/io/micrometer/docs/commons/ParsingUtils.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,11 @@ public static void updateKeyValuesFromEnum(JavaEnumImpl parentEnum, JavaSource<?
7171
return;
7272
}
7373
JavaEnumImpl myEnum = (JavaEnumImpl) source;
74-
if (!myEnum.getInterfaces().contains(requiredClass.getCanonicalName())) {
74+
String name = requiredClass.getName(); // requiredClass.getCanonicalName()
75+
if (name.contains("$")) {
76+
name = requiredClass.getName().substring(requiredClass.getName().lastIndexOf(".") + 1).replace("$", ".");
77+
}
78+
if (!myEnum.getInterfaces().contains(name)) {
7579
return;
7680
}
7781
logger.debug("Checking [" + parentEnum.getName() + "." + myEnum.getName() + "]");

micrometer-docs-generator-metrics/src/main/java/io/micrometer/docs/metrics/MetricSearchingFileVisitor.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import java.util.stream.Collectors;
3535
import java.util.stream.Stream;
3636

37-
import io.micrometer.common.Event;
3837
import io.micrometer.common.docs.KeyName;
3938
import io.micrometer.common.util.internal.logging.InternalLogger;
4039
import io.micrometer.common.util.internal.logging.InternalLoggerFactory;
@@ -239,7 +238,7 @@ else if ("overridesDefaultMetricFrom".equals(methodName)) {
239238
overridesDefaultMetricFrom = ParsingUtils.readClassToEnum(methodDeclaration);
240239
}
241240
else if ("getEvents".equals(methodName)) {
242-
Collection<KeyValueEntry> entries = ParsingUtils.keyValueEntries(myEnum, methodDeclaration, Event.class, "getName");
241+
Collection<KeyValueEntry> entries = ParsingUtils.keyValueEntries(myEnum, methodDeclaration, Observation.Event.class, "getName");
243242
Collection<MetricEntry> counters = entries.stream().map(k -> new MetricEntry(k.getName(), null, null, myEnum.getCanonicalName(), enumConstant.getName(), k.getDescription(), null, null, Meter.Type.COUNTER, new TreeSet<>(), new TreeSet<>(), null, new TreeSet<>())).collect(Collectors.toList());
244243
events.addAll(counters);
245244
}

micrometer-docs-generator-metrics/src/test/java/io/micrometer/docs/metrics/EventObservation.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package io.micrometer.docs.metrics;
1818

19-
import io.micrometer.common.Event;
19+
import io.micrometer.observation.Observation;
2020
import io.micrometer.observation.docs.DocumentedObservation;
2121

2222
enum EventObservation implements DocumentedObservation {
@@ -36,15 +36,15 @@ public String getContextualName() {
3636
}
3737

3838
@Override
39-
public Event[] getEvents() {
39+
public Observation.Event[] getEvents() {
4040
return Events.values();
4141
}
4242
};
4343

4444
/**
4545
* Observation events.
4646
*/
47-
enum Events implements Event {
47+
enum Events implements Observation.Event {
4848

4949
/**
5050
* Start event.

micrometer-docs-generator-spans/src/main/java/io/micrometer/docs/spans/SpanSearchingFileVisitor.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import java.util.stream.Collectors;
3535
import java.util.stream.Stream;
3636

37-
import io.micrometer.common.Event;
3837
import io.micrometer.common.docs.KeyName;
3938
import io.micrometer.common.util.internal.logging.InternalLogger;
4039
import io.micrometer.common.util.internal.logging.InternalLoggerFactory;
@@ -248,7 +247,7 @@ else if ("getEvents".equals(methodName)) {
248247
if (methodDeclaration.getReturnType2().toString().contains("EventValue")) {
249248
events.addAll(ParsingUtils.keyValueEntries(myEnum, methodDeclaration, EventValue.class));
250249
} else {
251-
events.addAll(ParsingUtils.keyValueEntries(myEnum, methodDeclaration, Event.class, "getContextualName"));
250+
events.addAll(ParsingUtils.keyValueEntries(myEnum, methodDeclaration, Observation.Event.class, "getContextualName"));
252251
}
253252
}
254253
else if ("getPrefix".equals(methodName)) {

micrometer-docs-generator-spans/src/test/java/io/micrometer/docs/spans/test1/EventObservation.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package io.micrometer.docs.spans.test1;
1818

19-
import io.micrometer.common.Event;
19+
import io.micrometer.observation.Observation;
2020
import io.micrometer.observation.docs.DocumentedObservation;
2121

2222
enum EventObservation implements DocumentedObservation {
@@ -36,15 +36,15 @@ public String getContextualName() {
3636
}
3737

3838
@Override
39-
public Event[] getEvents() {
39+
public Observation.Event[] getEvents() {
4040
return Events.values();
4141
}
4242
};
4343

4444
/**
4545
* Observation events.
4646
*/
47-
enum Events implements Event {
47+
enum Events implements Observation.Event {
4848

4949
/**
5050
* Start event.

0 commit comments

Comments
 (0)