dirPagination: make pagination template embedded

[luisrudge]

https://github.com/michaelbromley/angularUtils/tree/master/src/directives/pagination#specifying-the-template

The template should be embedded into the directive - accepting an path argument that overrides the default.

[michaelbromley]

Yeah this is something I am considering to make things simpler, especially for people who manage the module via Bower.

[luisrudge]

ok. I can fix that if you want :)

[michaelbromley]

Go for it! I would suggest a good place to put it would be in the paginationTemplateProvider: https://github.com/michaelbromley/angularUtils/blob/master/src/directives/pagination/dirPagination.js#L353

If you are familiar with Jasmine & Karma for unit tests, and have time to write a test for any changes you make, I will add you to my list of heroes. Tests are contained in the dirPagination.spec.js file.

[luisrudge]

do you think we need the provider at all?
I was thinking in replacing templateUrl for this:

template: function(elem, attrs) {
    if(attrs.templateUrl){
        return '<div ng-include="' + attrs.templateUrl + '"></div>'
    }
    return getStringTemplate(); //returns a string with the default template
}

[michaelbromley]

The provider is necessary to allow globally setting the templateUrl in the app's config block. For those who want to use a custom template, but not have to specify it in every instance of the directive, this is very useful.

[luisrudge]

ok, so i'll implement that in the provider! thanks for the tip

[luisrudge]

@michaelbromley Hi, cloning the repo and running 'grunt karma' fails :(

Error: [$injector:modulerr] Failed to instantiate module templates-main due to:
Error: [$injector:nomod] Module 'templates-main' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.

[luisrudge]

Oh, my fault. I should have ran only grunt to build the templates.

[luisrudge]

But the tests aren't passing either.

PhantomJS 1.9.8 (Windows 8) ordinalDate should leave the 'dd' format day alone FAILED
        Expected '14/11/2013' to equal '15/11/2013'.
        Error: Expected '14/11/2013' to equal '15/11/2013'.
            at c:/git/angularUtils/src/filters/ordinalDate/ordinalDate.spec.js:37
            at c:/git/angularUtils/node_modules/karma-jasmine/lib/boot.js:126
            at c:/git/angularUtils/node_modules/karma-jasmine/lib/adapter.js:171
            at http://localhost:9877/karma.js:185
            at http://localhost:9877/context.html:83
        Expected '2013-11-14' to equal '2013-11-15'.
        Error: Expected '2013-11-14' to equal '2013-11-15'.
            at c:/git/angularUtils/src/filters/ordinalDate/ordinalDate.spec.js:38
            at c:/git/angularUtils/node_modules/karma-jasmine/lib/boot.js:126
            at c:/git/angularUtils/node_modules/karma-jasmine/lib/adapter.js:171
            at http://localhost:9877/karma.js:185
            at http://localhost:9877/context.html:83
        Expected 'the 14th day of November' to equal 'the 15th day of November'.
        Error: Expected 'the 14th day of November' to equal 'the 15th day of November'.
            at c:/git/angularUtils/src/filters/ordinalDate/ordinalDate.spec.js:39
            at c:/git/angularUtils/node_modules/karma-jasmine/lib/boot.js:126
            at c:/git/angularUtils/node_modules/karma-jasmine/lib/adapter.js:171
            at http://localhost:9877/karma.js:185
            at http://localhost:9877/context.html:83
PhantomJS 1.9.8 (Windows 8): Executed 76 of 95 (3 FAILED) (0.735 secs / 0.93 secs)

I guess it's something related to DST?

[michaelbromley]

Strange. I recommend you just isolate the dirPagination tests by changing the first line to ddescribe which will run only that suite.

[luisrudge]

Yeah. I did that! Unfortunately I felt completely lost looking at the test. It doesn't test the templateUrl at all. I really don't know where to start :(

[michaelbromley]

Okay. Don't worry about it - it is probably not the easiest thing to write a test for to be honest, since you'd have to get into setting up a new module without the default template specified.

If you implemented it already you can just do a pull request without the test and I'll write the test when I get time and pull it in if it looks good.

[mpkorstanje]

What is the current status? I wouldn't mind submitting a pull request.

[michaelbromley]

Wow this is really old. I guess the original person dropped it since we've not heard anything for several months.

Feel free to submit a PR and I'll take a look.