Skip to content

Commit cd63a89

Browse files
author
Lee Jones
committed
mfd: ab3100-core: Correct code sytle problems
Corrects the following checkpatch gripes: WARNING: quoted string split across lines torvalds#95: FILE: drivers/mfd/ab3100-core.c:95: + "write error (write register) " + "%d bytes transferred (expected 2)\n", WARNING: quoted string split across lines torvalds#139: FILE: drivers/mfd/ab3100-core.c:139: + "write error (write test register) " + "%d bytes transferred (expected 2)\n", WARNING: quoted string split across lines torvalds#175: FILE: drivers/mfd/ab3100-core.c:175: + "write error (send register address) " + "%d bytes transferred (expected 1)\n", WARNING: quoted string split across lines torvalds#193: FILE: drivers/mfd/ab3100-core.c:193: + "write error (read register) " + "%d bytes transferred (expected 1)\n", WARNING: quoted string split across lines torvalds#241: FILE: drivers/mfd/ab3100-core.c:241: + "write error (send first register address) " + "%d bytes transferred (expected 1)\n", WARNING: quoted string split across lines torvalds#256: FILE: drivers/mfd/ab3100-core.c:256: + "write error (read register page) " + "%d bytes transferred (expected %d)\n", WARNING: quoted string split across lines torvalds#299: FILE: drivers/mfd/ab3100-core.c:299: + "write error (maskset send address) " + "%d bytes transferred (expected 1)\n", WARNING: quoted string split across lines torvalds#314: FILE: drivers/mfd/ab3100-core.c:314: + "write error (maskset read register) " + "%d bytes transferred (expected 1)\n", WARNING: quoted string split across lines torvalds#334: FILE: drivers/mfd/ab3100-core.c:334: + "write error (write register) " + "%d bytes transferred (expected 2)\n", WARNING: please, no spaces at the start of a line torvalds#374: FILE: drivers/mfd/ab3100-core.c:374: + return blocking_notifier_chain_unregister(&ab3100->event_subscribers,$ WARNING: Prefer seq_puts to seq_printf torvalds#458: FILE: drivers/mfd/ab3100-core.c:458: + seq_printf(s, "AB3100 registers:\n"); WARNING: quoted string split across lines torvalds#564: FILE: drivers/mfd/ab3100-core.c:564: + "debug write reg[0x%02x] with 0x%02x, " + "after readback: 0x%02x\n", WARNING: quoted string split across lines torvalds#723: FILE: drivers/mfd/ab3100-core.c:723: + "AB3100 P1E variant detected, " + "forcing chip to 32KHz\n"); WARNING: quoted string split across lines torvalds#882: FILE: drivers/mfd/ab3100-core.c:882: + "could not communicate with the AB3100 analog " + "baseband chip\n"); WARNING: quoted string split across lines torvalds#906: FILE: drivers/mfd/ab3100-core.c:906: + dev_err(&client->dev, "accepting it anyway. Please update " + "the driver.\n"); total: 0 errors, 15 warnings, 999 lines checked Reviewed-by: Linus Walleij <[email protected]> Signed-off-by: Lee Jones <[email protected]>
1 parent 0ebc1c2 commit cd63a89

File tree

1 file changed

+26
-28
lines changed

1 file changed

+26
-28
lines changed

‎drivers/mfd/ab3100-core.c‎

Lines changed: 26 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ static int ab3100_set_register_interruptible(struct ab3100 *ab3100,
9191
err);
9292
} else if (err != 2) {
9393
dev_err(ab3100->dev,
94-
"write error (write register) "
95-
"%d bytes transferred (expected 2)\n",
94+
"write error (write register)\n"
95+
" %d bytes transferred (expected 2)\n",
9696
err);
9797
err = -EIO;
9898
} else {
@@ -135,8 +135,8 @@ static int ab3100_set_test_register_interruptible(struct ab3100 *ab3100,
135135
err);
136136
} else if (err != 2) {
137137
dev_err(ab3100->dev,
138-
"write error (write test register) "
139-
"%d bytes transferred (expected 2)\n",
138+
"write error (write test register)\n"
139+
" %d bytes transferred (expected 2)\n",
140140
err);
141141
err = -EIO;
142142
} else {
@@ -171,8 +171,8 @@ static int ab3100_get_register_interruptible(struct ab3100 *ab3100,
171171
goto get_reg_out_unlock;
172172
} else if (err != 1) {
173173
dev_err(ab3100->dev,
174-
"write error (send register address) "
175-
"%d bytes transferred (expected 1)\n",
174+
"write error (send register address)\n"
175+
" %d bytes transferred (expected 1)\n",
176176
err);
177177
err = -EIO;
178178
goto get_reg_out_unlock;
@@ -189,8 +189,8 @@ static int ab3100_get_register_interruptible(struct ab3100 *ab3100,
189189
goto get_reg_out_unlock;
190190
} else if (err != 1) {
191191
dev_err(ab3100->dev,
192-
"write error (read register) "
193-
"%d bytes transferred (expected 1)\n",
192+
"write error (read register)\n"
193+
" %d bytes transferred (expected 1)\n",
194194
err);
195195
err = -EIO;
196196
goto get_reg_out_unlock;
@@ -237,8 +237,8 @@ static int ab3100_get_register_page_interruptible(struct ab3100 *ab3100,
237237
goto get_reg_page_out_unlock;
238238
} else if (err != 1) {
239239
dev_err(ab3100->dev,
240-
"write error (send first register address) "
241-
"%d bytes transferred (expected 1)\n",
240+
"write error (send first register address)\n"
241+
" %d bytes transferred (expected 1)\n",
242242
err);
243243
err = -EIO;
244244
goto get_reg_page_out_unlock;
@@ -252,8 +252,8 @@ static int ab3100_get_register_page_interruptible(struct ab3100 *ab3100,
252252
goto get_reg_page_out_unlock;
253253
} else if (err != numregs) {
254254
dev_err(ab3100->dev,
255-
"write error (read register page) "
256-
"%d bytes transferred (expected %d)\n",
255+
"write error (read register page)\n"
256+
" %d bytes transferred (expected %d)\n",
257257
err, numregs);
258258
err = -EIO;
259259
goto get_reg_page_out_unlock;
@@ -295,8 +295,8 @@ static int ab3100_mask_and_set_register_interruptible(struct ab3100 *ab3100,
295295
goto get_maskset_unlock;
296296
} else if (err != 1) {
297297
dev_err(ab3100->dev,
298-
"write error (maskset send address) "
299-
"%d bytes transferred (expected 1)\n",
298+
"write error (maskset send address)\n"
299+
" %d bytes transferred (expected 1)\n",
300300
err);
301301
err = -EIO;
302302
goto get_maskset_unlock;
@@ -310,8 +310,8 @@ static int ab3100_mask_and_set_register_interruptible(struct ab3100 *ab3100,
310310
goto get_maskset_unlock;
311311
} else if (err != 1) {
312312
dev_err(ab3100->dev,
313-
"write error (maskset read register) "
314-
"%d bytes transferred (expected 1)\n",
313+
"write error (maskset read register)\n"
314+
" %d bytes transferred (expected 1)\n",
315315
err);
316316
err = -EIO;
317317
goto get_maskset_unlock;
@@ -330,8 +330,8 @@ static int ab3100_mask_and_set_register_interruptible(struct ab3100 *ab3100,
330330
goto get_maskset_unlock;
331331
} else if (err != 2) {
332332
dev_err(ab3100->dev,
333-
"write error (write register) "
334-
"%d bytes transferred (expected 2)\n",
333+
"write error (write register)\n"
334+
" %d bytes transferred (expected 2)\n",
335335
err);
336336
err = -EIO;
337337
goto get_maskset_unlock;
@@ -371,7 +371,7 @@ EXPORT_SYMBOL(ab3100_event_register);
371371
int ab3100_event_unregister(struct ab3100 *ab3100,
372372
struct notifier_block *nb)
373373
{
374-
return blocking_notifier_chain_unregister(&ab3100->event_subscribers,
374+
return blocking_notifier_chain_unregister(&ab3100->event_subscribers,
375375
nb);
376376
}
377377
EXPORT_SYMBOL(ab3100_event_unregister);
@@ -455,7 +455,7 @@ static int ab3100_registers_print(struct seq_file *s, void *p)
455455
u8 value;
456456
u8 reg;
457457

458-
seq_printf(s, "AB3100 registers:\n");
458+
seq_puts(s, "AB3100 registers:\n");
459459

460460
for (reg = 0; reg < 0xff; reg++) {
461461
ab3100_get_register_interruptible(ab3100, reg, &value);
@@ -560,8 +560,8 @@ static ssize_t ab3100_get_set_reg(struct file *file,
560560
ab3100_get_register_interruptible(ab3100, user_reg, &regvalue);
561561

562562
dev_info(ab3100->dev,
563-
"debug write reg[0x%02x] with 0x%02x, "
564-
"after readback: 0x%02x\n",
563+
"debug write reg[0x%02x]\n"
564+
" with 0x%02x, after readback: 0x%02x\n",
565565
user_reg, user_value, regvalue);
566566
}
567567
return buf_size;
@@ -719,8 +719,7 @@ static int ab3100_setup(struct ab3100 *ab3100)
719719
*/
720720
if (ab3100->chip_id == 0xc4) {
721721
dev_warn(ab3100->dev,
722-
"AB3100 P1E variant detected, "
723-
"forcing chip to 32KHz\n");
722+
"AB3100 P1E variant detected forcing chip to 32KHz\n");
724723
err = ab3100_set_test_register_interruptible(ab3100,
725724
0x02, 0x08);
726725
}
@@ -878,8 +877,7 @@ static int ab3100_probe(struct i2c_client *client,
878877
&ab3100->chip_id);
879878
if (err) {
880879
dev_err(&client->dev,
881-
"could not communicate with the AB3100 analog "
882-
"baseband chip\n");
880+
"failed to communicate with AB3100 chip\n");
883881
goto exit_no_detect;
884882
}
885883

@@ -902,8 +900,8 @@ static int ab3100_probe(struct i2c_client *client,
902900
if (ids[i].id == 0x0) {
903901
dev_err(&client->dev, "unknown analog baseband chip id: 0x%x\n",
904902
ab3100->chip_id);
905-
dev_err(&client->dev, "accepting it anyway. Please update "
906-
"the driver.\n");
903+
dev_err(&client->dev,
904+
"accepting it anyway. Please update the driver.\n");
907905
goto exit_no_detect;
908906
}
909907

0 commit comments

Comments
 (0)