Skip to content

fix: add viewer's email to watermark #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfts merged 1 commit into from
Feb 19, 2025
Merged

fix: add viewer's email to watermark #1503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions components/view/dataroom/dataroom-document-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ type DEFAULT_DOCUMENT_VIEW_TYPE = {
isPreview?: boolean;
canDownload?: boolean;
verificationToken?: string;
viewerEmail?: string;
};

export default function DataroomDocumentView({
Expand Down Expand Up @@ -168,17 +169,18 @@ export default function DataroomDocumentView({
useAdvancedExcelViewer,
canDownload,
verificationToken,
viewerEmail,
} = fetchData as DEFAULT_DOCUMENT_VIEW_TYPE;
analytics.identify(
userEmail ?? verifiedEmail ?? data.email ?? undefined,
userEmail ?? viewerEmail ?? verifiedEmail ?? data.email ?? undefined,
);
analytics.capture("Link Viewed", {
linkId: link.id,
documentId: link.dataroomDocument.document.id,
dataroomId: link.dataroomId,
linkType: linkType,
viewerId: viewId,
viewerEmail: data.email ?? verifiedEmail ?? userEmail,
viewerEmail: viewerEmail ?? data.email ?? verifiedEmail ?? userEmail,
isEmbedded,
});

Expand Down Expand Up @@ -206,6 +208,7 @@ export default function DataroomDocumentView({
ipAddress,
useAdvancedExcelViewer,
canDownload,
viewerEmail,
}));
setSubmitted(true);
setVerificationRequested(false);
Expand Down Expand Up @@ -314,8 +317,16 @@ export default function DataroomDocumentView({
brand={brand}
showPoweredByBanner={false}
showAccountCreationSlide={false}
useAdvancedExcelViewer={useAdvancedExcelViewer}
viewerEmail={data.email ?? verifiedEmail ?? userEmail ?? undefined}
useAdvancedExcelViewer={
viewData.useAdvancedExcelViewer ?? useAdvancedExcelViewer
}
viewerEmail={
viewData.viewerEmail ??
data.email ??
verifiedEmail ??
userEmail ??
undefined
}
/>
) : (
<div className="flex h-screen items-center justify-center">
Expand Down
1 change: 1 addition & 0 deletions pages/api/views-dataroom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,6 +858,7 @@ export default async function handle(
? "notion"
: undefined,
watermarkConfig: link.enableWatermark ? link.watermarkConfig : undefined,
viewerEmail: viewer?.email ?? email ?? verifiedEmail ?? null,
ipAddress:
link.enableWatermark &&
link.watermarkConfig &&
Expand Down