Run tests maximized based on property, remove redundant test method argument.

Author: mfl28

src/test/java/com/github/mfl28/boundingboxeditor/BoundingBoxEditorTestBase.java

@@ -190,10 +190,7 @@ protected void onStart(Stage stage) {
         model = controller.getModel();
         // To make sure that the window is on top of all other windows at the start.
         stage.setAlwaysOnTop(true);
-
-        if(Boolean.getBoolean(FULL_SCREEN_TESTS_SYSTEM_PROPERTY_NAME)) {
-            stage.setMaximized(true);
-        }
+        stage.setMaximized(Boolean.getBoolean(FULL_SCREEN_TESTS_SYSTEM_PROPERTY_NAME));
 
         final Scene scene = createSceneFromParent(mainView);
         scene.getStylesheets().add(getClass().getResource(STYLESHEET_PATH).toExternalForm());
@@ -409,7 +406,7 @@ protected void timeOutAssertNoTopModelStage(FxRobot robot, TestInfo testinfo) {
                                                                                    TIMEOUT_DURATION_IN_SEC + "  sec."));
     }
 
-    protected void timeOutAssertThreadCount(FxRobot robot, String threadName, int count, TestInfo testinfo) {
+    protected void timeOutAssertThreadCount(String threadName, int count, TestInfo testinfo) {
         Assertions.assertDoesNotThrow(() -> WaitForAsyncUtils.waitFor(TIMEOUT_DURATION_IN_SEC, TimeUnit.SECONDS,
                                                                       () -> threadCount(threadName) == count),
                                       () -> saveScreenshotAndReturnMessage(testinfo,

src/test/java/com/github/mfl28/boundingboxeditor/ui/ImageFolderOpenedBasicTests.java

@@ -88,7 +88,7 @@ void onImageFolderOpened_WhenImageFileChanges_ShouldForceReloadFolder(FxRobot ro
                    saveScreenshot(testinfo));
 
         // Verify that exactly one Image file change watcher thread is running:
-        timeOutAssertThreadCount(robot, "ImageFileChangeWatcher", 1, testinfo);
+        timeOutAssertThreadCount("ImageFileChangeWatcher", 1, testinfo);
 
         // Rename the loaded image file:
         Assertions.assertDoesNotThrow(() -> Files.move(tempDir.toPath().resolve("foo.jpg"),
@@ -105,7 +105,7 @@ void onImageFolderOpened_WhenImageFileChanges_ShouldForceReloadFolder(FxRobot ro
 
         verifyThat(model.getCurrentImageFile(), Matchers.equalTo(tempDir.toPath().resolve("bar.jpg").toFile()),
                    saveScreenshot(testinfo));
-        timeOutAssertThreadCount(robot, "ImageFileChangeWatcher", 1, testinfo);
+        timeOutAssertThreadCount("ImageFileChangeWatcher", 1, testinfo);
 
         timeOutAssertNoTopModelStage(robot, testinfo);
 
@@ -129,7 +129,7 @@ void onImageFolderOpened_WhenImageFileChanges_ShouldForceReloadFolder(FxRobot ro
 
         WaitForAsyncUtils.waitForFxEvents();
 
-        timeOutAssertThreadCount(robot, "ImageFileChangeWatcher", 0, testinfo);
+        timeOutAssertThreadCount("ImageFileChangeWatcher", 0, testinfo);
 
         verifyThat(model.containsImageFiles(), Matchers.is(false), saveScreenshot(testinfo));
         verifyThat(mainView.isWorkspaceVisible(), Matchers.is(false), saveScreenshot(testinfo));
@@ -143,7 +143,7 @@ void onImageFolderOpened_WhenImageFileChanges_ShouldForceReloadFolder(FxRobot ro
 
         WaitForAsyncUtils.waitForFxEvents();
 
-        timeOutAssertThreadCount(robot, "ImageFileChangeWatcher", 0, testinfo);
+        timeOutAssertThreadCount("ImageFileChangeWatcher", 0, testinfo);
     }
 
     private void verifyNodeVisibilities(TestInfo testinfo) {