Refactor settings window fetching.

Author: mfl28

src/main/java/com/github/mfl28/boundingboxeditor/controller/Controller.java

@@ -229,7 +229,7 @@ public void onRegisterSettingsApplyAction(ActionEvent event, ButtonType buttonTy
             if(!inferenceSettingsView.validateSettings()) {
                 MainView.displayErrorAlert(SETTINGS_APPLICATION_ERROR_DIALOG_TITLE,
                                            SETTINGS_APPLICATION_INVALID_FIELDS_ERROR_DIALOG_CONTENT,
-                                           view.getSettingsWindow());
+                                           view.getSettingsWindow().orElse(stage));
                 event.consume();
                 return;
             }
@@ -238,7 +238,7 @@ public void onRegisterSettingsApplyAction(ActionEvent event, ButtonType buttonTy
                     inferenceSettingsView.getSelectedModelLabel().getText().equals("None")) {
                 MainView.displayErrorAlert(SETTINGS_APPLICATION_ERROR_DIALOG_TITLE,
                                            SETTINGS_APPLICATION_NO_MODEL_SELECTED_ERROR_DIALOG_CONTENT,
-                                           view.getSettingsWindow());
+                                           view.getSettingsWindow().orElse(stage));
                 event.consume();
                 return;
             }
@@ -363,7 +363,7 @@ public void onRegisterModelNameFetchingAction() {
         makeClientAvailable();
         modelNameFetchService.setClient(BoundingBoxPredictorClient.create(client, clientConfig));
         modelNameFetchService.getProgressViewer()
-                             .setParentWindow(view.getInferenceSettingsView().getScene().getWindow());
+                             .setParentWindow(view.getSettingsWindow().orElse(stage));
         modelNameFetchService.restart();
     }
 
@@ -858,22 +858,21 @@ private void onModelNameFetchingSucceeded(WorkerStateEvent event) {
             if(modelNames.isEmpty()) {
                 MainView.displayErrorAlert(MODEL_FETCHING_ERROR_DIALOG_TITLE,
                                            MODEL_FETCHING_NO_MODELS_ERROR_DIALOG_CONTENT,
-                                           view.getInferenceSettingsView().getScene().getWindow());
+                                           view.getSettingsWindow().orElse(stage));
             } else {
                 final Optional<String> modelChoice = MainView.displayChoiceDialogAndGetResult(modelNames.get(0),
                                                                                               modelNames,
                                                                                               MODEL_CHOICE_DIALOG_TITLE,
                                                                                               MODEL_CHOICE_DIALOG_HEADER,
                                                                                               MODEL_CHOICE_DIALOG_CONTENT,
-                                                                                              view.getInferenceSettingsView()
-                                                                                                  .getScene()
-                                                                                                  .getWindow());
+                                                                                              view.getSettingsWindow()
+                                                                                                  .orElse(stage));
                 modelChoice
                         .ifPresent(s -> view.getInferenceSettingsView().getSelectedModelLabel()
                                             .setText(s));
             }
         } else {
-            MainView.displayIOResultErrorInfoAlert(result, view.getInferenceSettingsView().getScene().getWindow());
+            MainView.displayIOResultErrorInfoAlert(result, view.getSettingsWindow().orElse(stage));
         }
     }
 

src/main/java/com/github/mfl28/boundingboxeditor/ui/MainView.java

@@ -529,12 +529,12 @@ public void displaySettingsDialog(Controller controller, Window owner) {
         settingsDialog.showAndWait();
     }
 
-    public Window getSettingsWindow() {
-        return List.of(inferenceSettingsView, uiSettingsView)
-                   .stream()
-                   .filter(item -> item.getScene() != null && item.getScene().getWindow() != null)
-                   .map(item -> item.getScene().getWindow())
-                   .findFirst().orElse(null);
+    public Optional<Window> getSettingsWindow() {
+        return Window.getWindows()
+                     .stream()
+                     .filter(window -> window instanceof Stage
+                             && ((Stage) window).getTitle().equals(SettingsDialogView.SETTINGS_TITLE))
+                     .findFirst();
     }
 
     private static void displayImageMetadataLoadingInfoAlert(IOResult ioResult, TableView<IOErrorInfoEntry> errorTable,

src/main/java/com/github/mfl28/boundingboxeditor/ui/settings/SettingsDialogView.java

@@ -32,8 +32,8 @@
 import java.util.Map;
 
 public class SettingsDialogView extends Dialog<ButtonType> implements View {
+    public static final String SETTINGS_TITLE = "Settings";
     private static final String SETTINGS_DIALOG_PANE_ID = "settings-dialog-pane";
-    private static final String SETTINGS_TITLE = "Settings";
     private static final double SPLITPANE_DIVIDER_POSITION = 0.35;
     private final ObservableList<String> settingCategories = FXCollections.observableArrayList();
     private final Map<String, Node> categoryToContentMap = new HashMap<>();