Skip to content

Commit 32cb8dc

Browse files
author
Thomas Hellström
committed
drm/xe: Fix xe_pt_stage_bind_walk kerneldoc
The structure was missing a proper kerneldoc header and once that was added a number of typos and errors became obvious. Fix those. Reported-by: Lucas De Marchi <lucas.demarchi@intel.com> Closes: https://lore.kernel.org/intel-xe/x53tcs5bjldw6lcorjemuheklxcmepdvr2u7lvt3hpqrzqoc4h@nsu6hs25taqj/ Fixes: b2d4b03 ("drm/xe: Make the PT code handle placement per PTE rather than per vma / range") Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Link: https://lore.kernel.org/r/20250402122924.25526-1-thomas.hellstrom@linux.intel.com
1 parent 89f306d commit 32cb8dc

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

drivers/gpu/drm/xe/xe_pt.c

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -269,23 +269,26 @@ struct xe_pt_update {
269269
bool preexisting;
270270
};
271271

272+
/**
273+
* struct xe_pt_stage_bind_walk - Walk state for the stage_bind walk.
274+
*/
272275
struct xe_pt_stage_bind_walk {
273-
/** base: The base class. */
276+
/** @base: The base class. */
274277
struct xe_pt_walk base;
275278

276279
/* Input parameters for the walk */
277280
/** @vm: The vm we're building for. */
278281
struct xe_vm *vm;
279282
/** @tile: The tile we're building for. */
280283
struct xe_tile *tile;
281-
/** @default_pte: PTE flag only template for VRAM. No address is associated */
284+
/** @default_vram_pte: PTE flag only template for VRAM. No address is associated */
282285
u64 default_vram_pte;
283-
/** @default_pte: PTE flag only template for VRAM. No address is associated */
286+
/** @default_system_pte: PTE flag only template for System. No address is associated */
284287
u64 default_system_pte;
285288
/** @dma_offset: DMA offset to add to the PTE. */
286289
u64 dma_offset;
287290
/**
288-
* @needs_64k: This address range enforces 64K alignment and
291+
* @needs_64K: This address range enforces 64K alignment and
289292
* granularity on VRAM.
290293
*/
291294
bool needs_64K;
@@ -301,6 +304,7 @@ struct xe_pt_stage_bind_walk {
301304
u64 va_curs_start;
302305

303306
/* Output */
307+
/** @wupd: Walk output data for page-table updates. */
304308
struct xe_walk_update {
305309
/** @wupd.entries: Caller provided storage. */
306310
struct xe_vm_pgtable_update *entries;
@@ -318,7 +322,7 @@ struct xe_pt_stage_bind_walk {
318322
u64 l0_end_addr;
319323
/** @addr_64K: The start address of the current 64K chunk. */
320324
u64 addr_64K;
321-
/** @found_64: Whether @add_64K actually points to a 64K chunk. */
325+
/** @found_64K: Whether @add_64K actually points to a 64K chunk. */
322326
bool found_64K;
323327
};
324328

0 commit comments

Comments
 (0)