Skip to content

Commit 72d0b6f

Browse files
author
Felipe Mello
committed
skip compiling instead of raising error
1 parent 08f5dc9 commit 72d0b6f

File tree

2 files changed

+16
-12
lines changed

2 files changed

+16
-12
lines changed

recipes/full_finetune_distributed.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -387,13 +387,15 @@ def setup(self, cfg: DictConfig) -> None:
387387
)
388388
if self._compile_optimizer_step:
389389
if self._optimizer_in_bwd:
390-
raise ValueError(
391-
"optimizer_in_bwd not supported with compiling the optimizer step"
390+
self._logger.warning(
391+
"Compile optimizer is not supported for optimizer_in_bwd. Setting self._compile_optimizer_step to False."
392+
)
393+
self._compile_optimizer_step = False
394+
else:
395+
self._optimizer.step = torch.compile(
396+
self._optimizer.step,
397+
backend=self._compile_backend,
392398
)
393-
self._optimizer.step = torch.compile(
394-
self._optimizer.step,
395-
backend=self._compile_backend,
396-
)
397399

398400
if self._resume_from_checkpoint:
399401
# If async checkpointing is enabled, intermediate checkpoints are saved asynchronously

recipes/qat_distributed.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -387,13 +387,15 @@ def setup(self, cfg: DictConfig) -> None:
387387
)
388388
if self._compile_optimizer_step:
389389
if self._optimizer_in_bwd:
390-
raise ValueError(
391-
"optimizer_in_bwd not supported with compiling the optimizer step"
390+
self._logger.warning(
391+
"Compile optimizer is not supported for optimizer_in_bwd. Setting self._compile_optimizer_step to False."
392+
)
393+
self._compile_optimizer_step = False
394+
else:
395+
self._optimizer.step = torch.compile(
396+
self._optimizer.step,
397+
backend=self._compile_backend,
392398
)
393-
self._optimizer.step = torch.compile(
394-
self._optimizer.step,
395-
backend=self._compile_backend,
396-
)
397399

398400
if self._resume_from_checkpoint:
399401
# If async checkpointing is enabled, intermediate checkpoints are saved asynchronously

0 commit comments

Comments
 (0)