fix corner case where train_pipeline PostProc can't trace through a fx wrap module #3377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
@TroyGarden has exported this pull request. If you are a Meta employee, you can view the originating diff in D82501416. |
…x wrap module (meta-pytorch#3377) Summary: # context * when working on UDD LSR MC5, we observed 5% QPS regression due to disabled SDD pipeline ([mast log](https://fburl.com/mlhub/rvuibmcp)) * the code change is mainly due to the `torch.fx.wrap` of a [postproc function](https://fburl.com/code/spvnz047) * although the `pipeline_postproc` flag is `True`, the issue is that it's actually a fx-wrapped function. * currently postproc trace only works for a torch.nn.Module, not a function. * added test case to verify this, and future work is needed to support better tracing for the fx-wrapped function. Reviewed By: spmex Differential Revision: D82501416
TroyGarden
force-pushed
the
export-D82501416
branch
from
c842614 to
b6fe33d
Compare
Contributor
|
@TroyGarden has exported this pull request. If you are a Meta employee, you can view the originating diff in D82501416. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
torch.fx.wrapof a postproc functionpipeline_postprocflag isTrue, the issue is that it's actually a fx-wrapped function.Differential Revision: D82501416