Skip to content

Commit a3c2066

Browse files
Mengdi Linfacebook-github-bot
authored andcommitted
remove compile options label from gbench (facebookresearch#3834)
Summary: Pull Request resolved: facebookresearch#3834 Looks like ServiceLab does not handle any metric that is not integer: https://fburl.com/code/chqi5hcr The current experiments are erroring with the message https://fburl.com/servicelab/99s69hbf: ``` ERROR:windtunnel.benchmarks.gbench_benchmark_runner.gbench_benchmark_runner:exception occurred while processing benchmark (this usually means a benchmark is misconfigured) faiss/perf_tests/scalar_quantizer_distance_test1/bench_scalar_quantizer_distance:QT_bf16_128d_2000n/iterations invalid literal for int() with base 10: 'OPTIMIZE AVX2 ' Traceback (most recent call last): File "windtunnel/benchmarks/gbench_benchmark_runner/gbench_benchmark_runner.py", line 116, in parse_gbench_results int(entry[metric_name]), ValueError: invalid literal for int() with base 10: 'OPTIMIZE AVX2 ' ``` Removing the label that's causing the failure. We can track the optimization mode via experiment names, or a dummy counter name in the future as I roll out multi-platform experiments. Differential Revision: D62166280
1 parent d296b2c commit a3c2066

4 files changed

Lines changed: 0 additions & 7 deletions

File tree

faiss/perf_tests/bench_scalar_quantizer_accuracy.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ static void bench_reconstruction_error(
2727
ScalarQuantizer::QuantizerType type,
2828
int d,
2929
int n) {
30-
state.SetLabel(faiss::get_compile_options());
3130
std::vector<float> x(d * n);
3231

3332
float_rand(x.data(), d * n, 12345);
@@ -64,7 +63,6 @@ static void bench_reconstruction_error(
6463
state.counters["ndiff_for_idempotence"] = ndiff;
6564

6665
state.counters["code_size_two"] = codes.size();
67-
state.SetLabel(faiss::get_compile_options());
6866
}
6967

7068
int main(int argc, char** argv) {

faiss/perf_tests/bench_scalar_quantizer_decode.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ static void bench_decode(
2727
ScalarQuantizer::QuantizerType type,
2828
int d,
2929
int n) {
30-
state.SetLabel(faiss::get_compile_options());
3130
std::vector<float> x(d * n);
3231

3332
float_rand(x.data(), d * n, 12345);

faiss/perf_tests/bench_scalar_quantizer_distance.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ static void bench_distance(
2727
ScalarQuantizer::QuantizerType type,
2828
int n,
2929
int d) {
30-
state.SetLabel(faiss::get_compile_options());
3130
std::vector<float> x(d * n);
3231

3332
float_rand(x.data(), d * n, 12345);
@@ -46,8 +45,6 @@ static void bench_distance(
4645
std::vector<uint8_t> codes(code_size * n);
4746
sq.compute_codes(x.data(), codes.data(), n);
4847

49-
state.SetLabel(faiss::get_compile_options());
50-
5148
std::unique_ptr<ScalarQuantizer::SQDistanceComputer> dc(
5249
sq.get_distance_computer());
5350
dc->codes = codes.data();

faiss/perf_tests/bench_scalar_quantizer_encode.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ static void bench_encode(
2828
ScalarQuantizer::QuantizerType type,
2929
int d,
3030
int n) {
31-
state.SetLabel(faiss::get_compile_options());
3231
std::vector<float> x(d * n);
3332

3433
float_rand(x.data(), d * n, 12345);

0 commit comments

Comments
 (0)