Skip to content

feat(crawl): includes/excludes fixes (FIR-1300) #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 6, 2025
Merged

feat(crawl): includes/excludes fixes (FIR-1300) #1303

merged 10 commits into from
Mar 6, 2025

Conversation

@mogery
Copy link
Member

@mogery mogery commented Mar 5, 2025 •
edited
Loading

  • Update includes/excludes behaviour to apply to the crawl source URL too (after discovery)
  • Add regexOnFullURL parameter

@mogery mogery requested a review from nickscamara as a code owner March 5, 2025 21:15
@mogery
Copy link
Member Author

mogery commented Mar 5, 2025

don't merge yet -- just running tests :)

@mogery
Copy link
Member Author

mogery commented Mar 6, 2025

ready @nickscamara

@mogery mogery changed the title feat(crawl): includes/excludes fixes feat(crawl): includes/excludes fixes (FIR-1300) Mar 6, 2025
@mogery
Copy link
Member Author

mogery commented Mar 6, 2025

@tomkosm adblock tests broken on f-e end

@mogery mogery merged commit e1cfe1d into main Mar 6, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickscamara nickscamara nickscamara approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mogery @nickscamara