Skip to content

Conversation

@FelonEkonom
Copy link
Member

No description provided.

@FelonEkonom FelonEkonom marked this pull request as draft September 19, 2025 14:21
@FelonEkonom FelonEkonom self-assigned this Sep 19, 2025
@FelonEkonom FelonEkonom moved this to In Progress in Smackore Sep 19, 2025
@FelonEkonom FelonEkonom changed the title Improve waiting on Live HLS segments mechanism Handle case when ex_hls has to add some latency to Live HLS stream Sep 22, 2025
@FelonEkonom FelonEkonom requested review from Copilot and varsill and removed request for Copilot September 22, 2025 12:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR handles cases when ExHLS needs to add latency to Live HLS streams by implementing proper asynchronous initialization of the ClientGenServer. Instead of blocking during initialization, the source element now waits for the ClientGenServer to be ready before proceeding with streaming operations.

Key changes:

  • Introduces asynchronous ClientGenServer initialization with timeout handling
  • Updates ExHLS dependency from 0.1.0 to 0.1.2
  • Adds proper state management for ClientGenServer readiness

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lib/membrane_http_adaptive_stream/source.ex Implements asynchronous ClientGenServer initialization with new status states and timeout handling
lib/membrane_http_adaptive_stream/source/client_genserver.ex Updates message name sent when ClientGenServer is ready
mix.exs Updates ExHLS dependency version and project version
README.md Updates installation version in documentation
test/membrane_http_adaptive_stream/integration_test/source_test.exs Adds test tag and comments out sleep duration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@varsill varsill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@FelonEkonom FelonEkonom marked this pull request as ready for review September 22, 2025 13:09
@FelonEkonom FelonEkonom merged commit f81f22e into master Sep 22, 2025
3 checks passed
@FelonEkonom FelonEkonom deleted the fix-waiting-bug branch September 22, 2025 13:10
@github-project-automation github-project-automation bot moved this from In Progress to Done in Smackore Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants