Skip to content

fix: catch file not found error when finding location snippet #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmonteiro merged 1 commit into from
Nov 23, 2025
+3 −8
Merged

fix: catch file not found error when finding location snippet #1673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions jscomp/core/ast_io.cppo.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ let set_input_lexbuf () =
in
begin match set_input_lexbuf !Location.input_name with
| (_ : Lexing.lexbuf) -> ()
| exception Unix.Unix_error (Unix.ENOENT, _, _)
| exception Sys_error _ -> ()
end

Expand Down
10 changes: 2 additions & 8 deletions test/blackbox-tests/ppx-location-snippet.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,8 @@ Test that the location snippet appears in a ppx-processed compilation error

$ export DUNE_SANDBOX=symlink
$ dune build @melange
File "dune", lines 1-4, characters 0-81:
1 | (melange.emit
2 | (target out)
3 | (emit_stdlib false)
4 | (preprocess (pps melange.ppx)))
melc: internal error, uncaught exception:
Unix.Unix_error(Unix.ENOENT, "open", "foo.ml")

File "foo.ml", line 1, characters 7-11:
Error: Unbound type constructor nope
[1]

$ export DUNE_SANDBOX=none
Expand Down
Loading