Skip to content

runtime: add new js array functions #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmonteiro merged 3 commits into from
Nov 2, 2025
Merged

runtime: add new js array functions #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d510ff
runtime: add new js array functions
eWert-Online Oct 25, 2025
80c79df
promote tests
eWert-Online Oct 25, 2025
298c67d
Merge branch 'main' into main
anmonteiro Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ Unreleased
- Upgrade the Melange JS parser to [Flow
v0.288.0](https://github.com/facebook/flow/releases/tag/v0.288.0)
([#1627](https://github.com/melange-re/melange/pull/1627))
- runtime: add more functions to `Js.Array` module
([#1635](https://github.com/melange-re/melange/pull/1635))

- core: update reserved keywords list to account for new browser additions
([#1644](https://github.com/melange-re/melange/pull/1644))

Expand Down
63 changes: 62 additions & 1 deletion jscomp/runtime/js_array.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,34 @@ external fill : value:'a -> ?start:int -> ?end_:int -> ('a t[@mel.this]) -> 'a t
[@@mel.send]
(* ES2015 *)

external flat : ('a t t[@mel.this]) -> 'a t = "flat" [@@mel.send]
(* ES2019 *)

external pop : 'a t -> 'a option = "pop"
[@@mel.send] [@@mel.return undefined_to_opt]
(** https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/push *)
(** https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/pop *)

external push : value:'a -> ('a t[@mel.this]) -> int = "push" [@@mel.send]

external pushMany : values:'a array -> ('a t[@mel.this]) -> int = "push"
[@@mel.send] [@@mel.variadic]

external toReversed : 'a t -> 'a t = "toReversed" [@@mel.send]
(** returns a new array with the elements in reversed order. (ES2023) *)

external reverseInPlace : 'a t -> 'a t = "reverse" [@@mel.send]

external shift : 'a t -> 'a option = "shift"
[@@mel.send] [@@mel.return undefined_to_opt]

external toSorted : 'a t -> 'a t = "toSorted" [@@mel.send]
(** returns a new array with the elements sorted in ascending order. (ES2023) *)

external toSortedWith :
f:(('a -> 'a -> int)[@mel.uncurry]) -> ('a t[@mel.this]) -> 'a t = "toSorted"
[@@mel.send]
(** returns a new array with the elements sorted in ascending order. (ES2023) *)

external sortInPlace : 'a t -> 'a t = "sort" [@@mel.send]

external sortInPlaceWith :
Expand All @@ -77,13 +91,33 @@ external spliceInPlace :
start:int -> remove:int -> add:'a array -> ('a t[@mel.this]) -> 'a t
= "splice"
[@@mel.send] [@@mel.variadic]
(** changes the contents of the given array by removing or replacing existing elements and/or adding new elements in place.
returns a new array containing the removed elements.
*)

external toSpliced :
start:int -> remove:int -> add:'a array -> ('a t[@mel.this]) -> 'a t
= "toSpliced"
[@@mel.send] [@@mel.variadic]
(** returns a new array with some elements removed and/or replaced at a given index. (ES2023) *)

external removeFromInPlace : start:int -> ('a t[@mel.this]) -> 'a t = "splice"
[@@mel.send]
(** removes all elements from the given array starting at the [start] index and returns the removed elements. *)

external removeFrom : start:int -> ('a t[@mel.this]) -> 'a t = "toSpliced"
[@@mel.send]
(** returns a new array with elements removed starting at the [start] index. (ES2023) *)

external removeCountInPlace :
start:int -> count:int -> ('a t[@mel.this]) -> 'a t = "splice"
[@@mel.send]
(** removes [count] elements from the given array starting at the [start] index and returns the removed elements. *)

external removeCount :
start:int -> count:int -> ('a t[@mel.this]) -> 'a t = "toSpliced"
[@@mel.send]
(** returns a new array with [count] elements removed starting at the [start] index. (ES2023) *)

external unshift : value:'a -> ('a t[@mel.this]) -> int = "unshift" [@@mel.send]

Expand All @@ -104,6 +138,11 @@ external join : ?sep:string -> ('a t[@mel.this]) -> string = "join" [@@mel.send]

(** Accessor functions *)

external at : index:int -> ('a t[@mel.this]) -> 'a option
= "at"
[@@mel.send] [@@mel.return { undefined_to_opt }]
(** ES2022 *)

external indexOf : value:'a -> ?start:int -> ('a t[@mel.this]) -> int
= "indexOf"
[@@mel.send]
Expand Down Expand Up @@ -154,6 +193,17 @@ external findi :
[@@mel.send] [@@mel.return { undefined_to_opt }]
(* ES2015 *)

external findLast : f:(('a -> bool)[@mel.uncurry]) -> ('a t[@mel.this]) -> 'a option
= "findLast"
[@@mel.send] [@@mel.return { undefined_to_opt }]
(* ES2015 *)

external findLasti :
f:(('a -> int -> bool)[@mel.uncurry]) -> ('a t[@mel.this]) -> 'a option
= "findLast"
[@@mel.send] [@@mel.return { undefined_to_opt }]
(* ES2015 *)

external findIndex : f:(('a -> bool)[@mel.uncurry]) -> ('a t[@mel.this]) -> int
= "findIndex"
[@@mel.send]
Expand All @@ -165,6 +215,17 @@ external findIndexi :
[@@mel.send]
(* ES2015 *)

external findLastIndex : f:(('a -> bool)[@mel.uncurry]) -> ('a t[@mel.this]) -> int
= "findLastIndex"
[@@mel.send]
(* ES2015 *)

external findLastIndexi :
f:(('a -> int -> bool)[@mel.uncurry]) -> ('a t[@mel.this]) -> int
= "findLastIndex"
[@@mel.send]
(* ES2015 *)

external forEach : f:(('a -> unit)[@mel.uncurry]) -> ('a t[@mel.this]) -> unit
= "forEach"
[@@mel.send]
Expand Down
Loading
Loading