Skip to content

Commit c119ed0

Browse files
committed
fix: remove erroneous get() API from usePuck
1 parent 93d525c commit c119ed0

2 files changed

Lines changed: 5 additions & 11 deletions

File tree

apps/demo/app/custom-ui/[...puckPath]/client.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
"use client";
55

6-
import { ActionBar, Button, Data, Puck, Render } from "@/core";
6+
import { ActionBar, Button, Data, Puck, Render, useGetPuck } from "@/core";
77
import { HeadingAnalyzer } from "@/plugin-heading-analyzer/src/HeadingAnalyzer";
88
import config from "../../../config";
99
import { UserConfig } from "../../../config/types";
@@ -16,7 +16,7 @@ import { ChevronUp, ChevronDown, Globe, Lock, Unlock } from "lucide-react";
1616
const usePuck = createUsePuck<UserConfig>();
1717

1818
const CustomHeader = ({ onPublish }: { onPublish: (data: Data) => void }) => {
19-
const get = usePuck((s) => s.get);
19+
const getPuck = useGetPuck();
2020
const dispatch = usePuck((s) => s.dispatch);
2121
const previewMode = usePuck((s) => s.appState.ui.previewMode);
2222

@@ -50,7 +50,7 @@ const CustomHeader = ({ onPublish }: { onPublish: (data: Data) => void }) => {
5050
Switch to {previewMode === "edit" ? "interactive" : "edit"}
5151
</Button>
5252
<Button
53-
onClick={() => onPublish(get().appState.data)}
53+
onClick={() => onPublish(getPuck().appState.data)}
5454
icon={<Globe size="14" />}
5555
>
5656
Publish

packages/core/lib/use-puck.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ import { createStore, StoreApi, useStore } from "zustand";
1010
import { makeStatePublic } from "./data/make-state-public";
1111
import { getItem, ItemSelector } from "./data/get-item";
1212

13-
type WithGet<T> = T & { get: () => T };
14-
1513
export type UsePuckData<
1614
UserConfig extends Config = Config,
1715
G extends UserGenerics<UserConfig> = UserGenerics<UserConfig>
@@ -40,9 +38,7 @@ export type UsePuckData<
4038
export type PuckApi<UserConfig extends Config = Config> =
4139
UsePuckData<UserConfig>;
4240

43-
type UsePuckStore<UserConfig extends Config = Config> = WithGet<
44-
PuckApi<UserConfig>
45-
>;
41+
type UsePuckStore<UserConfig extends Config = Config> = PuckApi<UserConfig>;
4642

4743
type PickedStore = Pick<
4844
AppStore,
@@ -85,9 +81,7 @@ export const generateUsePuck = (store: PickedStore): UsePuckStore => {
8581
},
8682
};
8783

88-
const get = () => storeData;
89-
90-
return { ...storeData, get };
84+
return storeData;
9185
};
9286

9387
export const UsePuckStoreContext = createContext<StoreApi<UsePuckStore> | null>(

0 commit comments

Comments
 (0)