-
Notifications
You must be signed in to change notification settings - Fork 23k
Remove remaining active learning and old editors #40832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining active learning and old editors #40832
Conversation
files/en-us/learn_web_development/howto/web_mechanics/how_does_the_internet_work/index.md
Outdated
Show resolved
Hide resolved
| 3. Select the _Share or embed map_ option. | ||
| 4. Select the Embed map option, which will give you some `<iframe>` code — copy this. | ||
| 5. Insert it into the _Input_ box below, and see what the result is in the _Output_. | ||
| ```html live-sample___embedding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we don't need the code blocks at all, you can link to https://developer.mozilla.org/en-US/play directly instead of saying "press the play button"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you wanted to have the HTML block hidden with a finished iframe embed, and have people replace it with a new one to see what's involved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good idea. I've removed the code blocks as suggested and tweaked the wording to suit.
...us/learn_web_development/core/structuring_content/including_vector_graphics_in_html/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere on this page, would write "SVG is easy to hand code" as "SVG is easy to hand-code"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
bsmth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to consider, but a +1 for you for when you've had a look 👀
TY!
…_the_internet_work/index.md Co-authored-by: Brian Smith <[email protected]>
…luding_vector_graphics_in_html/index.md Co-authored-by: Brian Smith <[email protected]>
Description
There were a few more instances of "Active learning" language around MDN, plus a couple of old live code editors lying around. This PR:
Motivation
Additional details
Related issues and pull requests