use go-kzg PolyLinComb instead of local impl

roberto-bayardo · roberto-bayardo · commit bca26b3cb8bf · 2022-11-08T12:00:11.000-08:00
diff --git a/core/types/data_blob.go b/core/types/data_blob.go
@@ -606,7 +606,10 @@ func computeAggregateKzgCommitment(blobs Blobs, commitments []KZGCommitment) ([]
 	if err != nil {
 		return nil, nil, err
 	}
-	aggregatePoly := kzg.MatrixLinComb(polys, powers)
+	aggregatePoly, err := bls.PolyLinComb(polys, powers)
+	if err != nil {
+		return nil, nil, err
+	}
 	return aggregatePoly, aggregateCommitmentG1, nil
 }
 
diff --git a/crypto/kzg/util.go b/crypto/kzg/util.go
@@ -32,18 +32,6 @@ func initDomain() {
 	}
 }
 
-func MatrixLinComb(vectors [][]bls.Fr, scalars []bls.Fr) []bls.Fr {
-	r := make([]bls.Fr, len(vectors[0]))
-	for i := 0; i < len(vectors); i++ {
-		var tmp bls.Fr
-		for j := 0; j < len(r); j++ {
-			bls.MulModFr(&tmp, &vectors[i][j], &scalars[i])
-			bls.AddModFr(&r[j], &r[j], &tmp)
-		}
-	}
-	return r
-}
-
 // EvaluatePolyInEvaluationForm evaluates the polynomial using the barycentric formula
 func EvaluatePolyInEvaluationForm(yFr *bls.Fr, poly []bls.Fr, x *bls.Fr) {
 	bls.EvaluatePolyInEvaluationForm(yFr, poly, x, DomainFr, 0)
diff --git a/go.mod b/go.mod
@@ -50,7 +50,7 @@ require (
 	github.com/olekukonko/tablewriter v0.0.5
 	github.com/peterh/liner v1.1.1-0.20190123174540-a2c9a5303de7
 	github.com/prometheus/tsdb v0.7.1
-	github.com/protolambda/go-kzg v0.0.0-20221025081131-f3a74d3b1d0c
+	github.com/protolambda/go-kzg v0.0.0-20221108193918-c6d0faa55038
 	github.com/protolambda/ztyp v0.2.1
 	github.com/rjeczalik/notify v0.9.1
 	github.com/rs/cors v1.7.0
diff --git a/go.sum b/go.sum
@@ -364,8 +364,8 @@ github.com/prometheus/procfs v0.0.0-20181005140218-185b4288413d/go.mod h1:c3At6R
 github.com/prometheus/procfs v0.0.2/go.mod h1:TjEm7ze935MbeOT/UhFTIMYKhuLP4wbCsTZCD3I8kEA=
 github.com/prometheus/tsdb v0.7.1 h1:YZcsG11NqnK4czYLrWd9mpEuAJIHVQLwdrleYfszMAA=
 github.com/prometheus/tsdb v0.7.1/go.mod h1:qhTCs0VvXwvX/y3TZrWD7rabWM+ijKTux40TwIPHuXU=
-github.com/protolambda/go-kzg v0.0.0-20221025081131-f3a74d3b1d0c h1:9PBJD0rbR2dsgzUoi7GGbCJ3PZssM2eK//tHaAVS5Ds=
-github.com/protolambda/go-kzg v0.0.0-20221025081131-f3a74d3b1d0c/go.mod h1:9Lk5SNX/61jq4lbyYcxCvOeldv4xEUAO6QMp/Fd5ALw=
+github.com/protolambda/go-kzg v0.0.0-20221108193918-c6d0faa55038 h1:oTNfeC6fvE/m3iT62hR+umMXjdjtnhCQ6ez9Kl4Gwu0=
+github.com/protolambda/go-kzg v0.0.0-20221108193918-c6d0faa55038/go.mod h1:9Lk5SNX/61jq4lbyYcxCvOeldv4xEUAO6QMp/Fd5ALw=
 github.com/protolambda/ztyp v0.2.1 h1:+rfw75/Zh8EopNlG652TGDXlLgJflj6XWxJ9yCVpJws=
 github.com/protolambda/ztyp v0.2.1/go.mod h1:9bYgKGqg3wJqT9ac1gI2hnVb0STQq7p/1lapqrqY1dU=
 github.com/retailnext/hllpp v1.0.1-0.20180308014038-101a6d2f8b52/go.mod h1:RDpi1RftBQPUCDRw6SmxeaREsAaRKnOclghuzp/WRzc=

Original file line number	Diff line number	Diff line change
`@@ -606,7 +606,10 @@ func computeAggregateKzgCommitment(blobs Blobs, commitments []KZGCommitment) ([]`
`606`	`606`	`if err != nil {`
`607`	`607`	`return nil, nil, err`
`608`	`608`	`}`
`609`		`- aggregatePoly := kzg.MatrixLinComb(polys, powers)`
	`609`	`+ aggregatePoly, err := bls.PolyLinComb(polys, powers)`
	`610`	`+ if err != nil {`
	`611`	`+ return nil, nil, err`
	`612`	`+ }`
`610`	`613`	`return aggregatePoly, aggregateCommitmentG1, nil`
`611`	`614`	`}`
`612`	`615`
-Original file line number
+Diff line change
 	github.com/olekukonko/tablewriter v0.0.5
 	github.com/peterh/liner v1.1.1-0.20190123174540-a2c9a5303de7
 	github.com/prometheus/tsdb v0.7.1
 -	github.com/protolambda/go-kzg v0.0.0-20221025081131-f3a74d3b1d0c
 +	github.com/protolambda/go-kzg v0.0.0-20221108193918-c6d0faa55038
 	github.com/protolambda/ztyp v0.2.1
 	github.com/rjeczalik/notify v0.9.1
 	github.com/rs/cors v1.7.0