Add missing stdlib requires. #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using super_diff in an RSpec suite that does not load `set` or `delegate` from the standard library, I was getting errors: * `NameError: uninitialized constant SuperDiff::RecursionGuard::Set` * `NameError: uninitialized constant SuperDiff::OperationTrees::SimpleDelegator` The requires added here fix these errors. super_diff should load all parts of the stdlib it uses rather than assuming other things load them.
Collaborator
|
Hi @myronmarston! Good catch. Looks like I need to change the integration tests to catch these kinds of things in the future. In the meantime, thanks for the fix! |
Collaborator
|
Just released 0.5.2 which includes this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using super_diff in an RSpec suite that does not load
setor
delegatefrom the standard library, I was getting errors:NameError: uninitialized constant SuperDiff::RecursionGuard::SetNameError: uninitialized constant SuperDiff::OperationTrees::SimpleDelegatorThe requires added here fix these errors.
super_diff should load all parts of the stdlib it uses rather than
assuming other things load them.