Fix compatibility issues with rspec-rails #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
fix-compat-with-rspec-rails
branch
2 times, most recently
from
b4c70f4 to
a39b9ee
Compare
With 0.6.0, requiring `super_diff/rspec-rails` in the context of `rspec-rails` suddenly started failing. We try to require `rspec/version` so that we can have access to RSpec::Version. However, `rspec-rails` does not depend on the `rspec` metagem, so RSpec::Version is not a constant when using `rspec-rails`. In addition, this was never caught because it turns out that integration with `rspec-rails` was not being properly tested. This commit fixes `super_diff` to reference RSpec::Core::Version (since we can always assume `rspec-core` has been loaded) and makes sure that we are testing it so the aforementioned problem does not occur again.
mcmire
force-pushed
the
fix-compat-with-rspec-rails
branch
from
a39b9ee to
52b691d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 0.6.0, requiring
super_diff/rspec-railsin the context ofrspec-railssuddenly started failing. We try to requirerspec/versionso that we can have access to RSpec::Version. However,rspec-railsdoes not depend on therspecmetagem, so RSpec::Versionis not a constant when using
rspec-rails. In addition, this was nevercaught because it turns out that integration with
rspec-railswas notbeing properly tested.
This commit fixes
super_diffto reference RSpec::Core::Version (sincewe can always assume
rspec-corehas been loaded) and makes sure thatwe are testing it so the aforementioned problem does not occur again.
Fixes #120.