workflows: bump golang lint versions

Author: NARSimoes

.github/workflows/ci.yml

@@ -40,7 +40,7 @@ jobs:
     - name: Run golangci-lint
       uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20  # v9.2.0
       with:
-        version: v1.64.8  # need to be updated
+        version: v2.8.0
         working-directory: focalboard/server
 
   dist:

.github/workflows/lint-server.yml

@@ -38,5 +38,5 @@ jobs:
       - name: Run golangci-lint
         uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20  # v9.2.0
         with:
-          version: v1.64.8  # need to be updated
+          version: v2.8.0
           working-directory: focalboard/server

server/.golangci.yml

@@ -1,80 +1,89 @@
+version: "2"
 run:
-  timeout: 5m
   modules-download-mode: readonly
-
-linters-settings:
-  gofmt:
-    simplify: true
-  goimports:
-    local-prefixes: github.com/mattermost/mattermost-starter-template
-  golint:
-    min-confidence: 0
-  govet:
-    enable-all: true
-    disable:
-      - fieldalignment
-  misspell:
-    locale: US
-  lll:
-    line-length: 150
-  revive:
-    enableAllRules: true
-    rules:
-      - name: exported
-        disabled: true
-
 linters:
-  disable-all: true
-  settings:
-    govet:
-      enable:
-        - shadow
+  default: none
   enable:
-    - gofmt
-    - goimports
-    - ineffassign
-    - unparam
-    - govet
+    - asciicheck
     - bodyclose
+    - copyloopvar
+    - dogsled
     - durationcheck
+    - err113
     - errorlint
     - exhaustive
-    - copyloopvar
-    - gosec
-    - makezero
-    - staticcheck
-    - prealloc
-    - asciicheck
-    - dogsled
     - gocritic
+    - gocyclo
     - godot
-    - err113
     - goheader
-    - revive
-    - nakedret
     - gomodguard
     - goprintffuncname
-    - gosimple
+    - gosec
+    - govet
+    - ineffassign
+    - makezero
     - misspell
+    - nakedret
     - nolintlint
-    - typecheck
+    - prealloc
+    - revive
+    - staticcheck
     - unconvert
+    - unparam
     - unused
     - whitespace
-    - gocyclo
-
-issues:
-  exclude-files:
-    - product/boards_product.go
-    - services/store/sqlstore/migrations
-  exclude-rules:
-    - path: server/manifest.go
-      linters:
-        - unused
-    - path: server/configuration.go
-      linters:
-        - unused
-    - path: _test\.go
-      linters:
-        - bodyclose
-        - scopelint # https://github.com/kyoh86/scopelint/issues/4
+  settings:
+    govet:
+      disable:
+        - fieldalignment
+      enable-all: true
+    lll:
+      line-length: 150
+    misspell:
+      locale: US
+    revive:
+      rules:
+        - name: exported
+          disabled: true
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - unused
+        path: server/manifest.go
+      - linters:
+          - unused
+        path: server/configuration.go
+      - linters:
+          - bodyclose
+          - scopelint
+        path: _test\.go
+    paths:
+      - product/boards_product.go
+      - services/store/sqlstore/migrations
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    gofmt:
+      simplify: true
+    goimports:
+      local-prefixes:
+        - github.com/mattermost/mattermost-starter-template
+  exclusions:
+    generated: lax
+    paths:
+      - product/boards_product.go
+      - services/store/sqlstore/migrations
+      - third_party$
+      - builtin$
+      - examples$