Check already streamed instances in addition to new descendants. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I agree that this can be useful, but I need to take time to consider the exact place in the API and release schedule this should take, so it may be a little while before I get to approving it. |
Author
|
Might take a little longer - I ended up finding a bug in this related to workspace.SignalBehavior.Deferred - For some reason, in some cases, an instance will never be passed that has been replicated to the client. I have no thoughts on why this is, but am looking into it. |
Author
|
I'm not sure if you want to close this pull request, but the only thing I found was to use CollectionService which works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how :queryChanged returns a record of all records prior to the first call to queryChanged, it would be useful for the result of useStream to do an initial check for any entities that streamed prior to my initial call.