Fix portability issues to Linux, FreeBSD, and older libc++

Summary: Pull Request resolved: facebook#21764

Differential Revision: D13902907

Pulled By: hramos

fbshipit-source-id: 640cde865b1bcc5ca43c17d00574b8e2f78ceaf4

Author: matthargett

ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.cpp

@@ -153,7 +153,7 @@ void CatalystInstanceImpl::initializeBridge(
        moduleMessageQueue_));
 
   instance_->initializeBridge(
-    folly::make_unique<JInstanceCallback>(
+    std::make_unique<JInstanceCallback>(
     callback,
     moduleMessageQueue_),
     jseh->getExecutorFactory(),

ReactCommon/cxxreact/Instance.cpp

@@ -43,7 +43,6 @@ void Instance::initializeBridge(
     std::shared_ptr<ModuleRegistry> moduleRegistry) {
   callback_ = std::move(callback);
   moduleRegistry_ = std::move(moduleRegistry);
-
   jsQueue->runOnQueueSync([this, &jsef, jsQueue]() mutable {
     nativeToJsBridge_ = folly::make_unique<NativeToJsBridge>(
         jsef.get(), moduleRegistry_, jsQueue, callback_);

ReactCommon/cxxreact/JSBigString.h

@@ -6,6 +6,7 @@
 #pragma once
 
 #include <fcntl.h>
+#include <unistd.h>
 #include <sys/mman.h>
 #include <unistd.h>
 

ReactCommon/cxxreact/JSExecutor.h

@@ -82,8 +82,7 @@ class RN_EXPORT JSExecutor {
    */
   virtual void invokeCallback(const double callbackId, const folly::dynamic& arguments) = 0;
 
-  virtual void setGlobalVariable(std::string propName,
-                                 std::unique_ptr<const JSBigString> jsonValue) = 0;
+  virtual void setGlobalVariable(std::string propName, std::unique_ptr<const JSBigString> jsonValue) = 0;
 
   virtual void* getJavaScriptContext() {
     return nullptr;

ReactCommon/cxxreact/JsArgumentHelpers-inl.h

@@ -4,6 +4,7 @@
 // LICENSE file in the root directory of this source tree.
 
 #pragma once
+#include <folly/dynamic.h>
 
 namespace facebook {
 namespace xplat {

ReactCommon/cxxreact/NativeToJsBridge.cpp

@@ -103,6 +103,7 @@ void NativeToJsBridge::loadApplication(
     std::unique_ptr<RAMBundleRegistry> bundleRegistry,
     std::unique_ptr<const JSBigString> startupScript,
     std::string startupScriptSourceURL) {
+
   runOnExecutorQueue(
       [this,
        bundleRegistryWrap=folly::makeMoveWrapper(std::move(bundleRegistry)),

ReactCommon/jsi/JSCRuntime.cpp

@@ -200,7 +200,11 @@ class JSCRuntime : public jsi::Runtime {
 #endif
 };
 
-#if __has_builtin(__builtin_expect)
+#ifndef __has_builtin
+#define __has_builtin(x) 0
+#endif
+
+#if __has_builtin(__builtin_expect) || defined(__GNUC__)
 #define JSC_LIKELY(EXPR) __builtin_expect((bool)(EXPR), true)
 #define JSC_UNLIKELY(EXPR) __builtin_expect((bool)(EXPR), false)
 #else

ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp

@@ -14,6 +14,7 @@
 #include <glog/logging.h>
 #include <jsi/JSIDynamic.h>
 
+#include <sstream>
 #include <stdexcept>
 
 using namespace facebook::jsi;

ReactCommon/microprofiler/MicroProfiler.cpp

@@ -6,6 +6,7 @@
 #include <algorithm>
 #include <chrono>
 #include <mutex>
+#include <sstream>
 #include <vector>
 #include <time.h>
 
@@ -17,7 +18,7 @@
 // we can get rid of this
 #if defined(__APPLE__)
 #define MICRO_PROFILER_STUB_IMPLEMENTATION 1
-#else
+#elif !defined(MICRO_PROFILER_STUB_IMPLEMENTATION)
 #define MICRO_PROFILER_STUB_IMPLEMENTATION 0
 #endif