Ignore unknown conditions to fix unit tests

Author: erikjohnston

rust/src/push/evaluator.rs

@@ -142,14 +142,8 @@ impl PushRuleEvaluator {
     ) -> Result<bool, Error> {
         let known_condition = match condition {
             Condition::Known(known) => known,
-
-            // XXX This looks incorrect -- we have reached an unknown condition
-            // kind and are unconditionally returning that it matches. Note that
-            // it seems possible to provide a condition to the /pushrules
-            // endpoint with an unknown kind, see
-            // _rule_tuple_from_request_object.
             Condition::Unknown(_) => {
-                return Ok(true);
+                return Ok(false);
             }
         };
 

tests/push/test_push_rule_evaluator.py

@@ -305,9 +305,6 @@ def test_relation_match(self) -> None:
         evaluator = self._get_evaluator(
             {}, {"m.annotation": {("@user:test", "m.reaction")}}
         )
-        condition = {"kind": "relation_match"}
-        # Oddly, an unknown condition always matches.
-        self.assertTrue(evaluator.matches(condition, "@user:test", "foo"))
 
         # A push rule evaluator with the experimental rule enabled.
         evaluator = self._get_evaluator(