Use servers list approx to send read receipts when in partial state (#14549)

Mathieu Velten · web-flow · commit 4569eda94423 · 2022-11-30T13:39:47.000+01:00
Signed-off-by: Mathieu Velten &lt;mathieuv@matrix.org&gt;
diff --git a/changelog.d/14549.misc b/changelog.d/14549.misc
@@ -0,0 +1 @@
+Faster joins: use servers list approximation to send read receipts when in partial state instead of waiting for the full state of the room.
diff --git a/synapse/federation/sender/__init__.py b/synapse/federation/sender/__init__.py
@@ -647,7 +647,7 @@ async def send_read_receipt(self, receipt: ReadReceipt) -> None:
         room_id = receipt.room_id
 
         # Work out which remote servers should be poked and poke them.
-        domains_set = await self._storage_controllers.state.get_current_hosts_in_room(
+        domains_set = await self._storage_controllers.state.get_current_hosts_in_room_or_partial_state_approximation(
             room_id
         )
         domains = [
diff --git a/tests/federation/test_federation_sender.py b/tests/federation/test_federation_sender.py
@@ -38,6 +38,10 @@ def make_homeserver(self, reactor, clock):
             return_value=make_awaitable({"test", "host2"})
         )
 
+        hs.get_storage_controllers().state.get_current_hosts_in_room_or_partial_state_approximation = (
+            hs.get_storage_controllers().state.get_current_hosts_in_room
+        )
+
         return hs
 
     @override_config({"send_federation": True})

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Faster joins: use servers list approximation to send read receipts when in partial state instead of waiting for the full state of the room.`
Original file line number	Diff line number	Diff line change
`@@ -647,7 +647,7 @@ async def send_read_receipt(self, receipt: ReadReceipt) -> None:`
`647`	`647`	`room_id = receipt.room_id`
`648`	`648`
`649`	`649`	`# Work out which remote servers should be poked and poke them.`
`650`		`- domains_set = await self._storage_controllers.state.get_current_hosts_in_room(`
	`650`	`+ domains_set = await self._storage_controllers.state.get_current_hosts_in_room_or_partial_state_approximation(`
`651`	`651`	`room_id`
`652`	`652`	`)`
`653`	`653`	`domains = [`
Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,10 @@ def make_homeserver(self, reactor, clock):`
`38`	`38`	`return_value=make_awaitable({"test", "host2"})`
`39`	`39`	`)`
`40`	`40`
	`41`	`+ hs.get_storage_controllers().state.get_current_hosts_in_room_or_partial_state_approximation = (`
	`42`	`+ hs.get_storage_controllers().state.get_current_hosts_in_room`
	`43`	`+ )`
	`44`	`+`
`41`	`45`	`return hs`
`42`	`46`
`43`	`47`	`@override_config({"send_federation": True})`