Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 84af29a

Browse files
authored
Merge pull request #6452 from SimonBrandner/fix/bubble-bg-color/18081
2 parents 8c5cfe6 + ca94518 commit 84af29a

3 files changed

Lines changed: 33 additions & 24 deletions

File tree

res/themes/dark/css/_dark.scss

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Colors from Figma Compound https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=557%3A0
2+
$system-dark: #21262C;
3+
14
// unified palette
25
// try to use these colors when possible
36
$bg-color: #15191E;
@@ -47,7 +50,7 @@ $inverted-bg-color: $base-color;
4750
$selected-color: $room-highlight-color;
4851

4952
// selected for hoverover & selected event tiles
50-
$event-selected-color: #21262c;
53+
$event-selected-color: $system-dark;
5154

5255
// used for the hairline dividers in RoomView
5356
$primary-hairline-color: transparent;
@@ -91,7 +94,7 @@ $lightbox-background-bg-color: #000;
9194
$lightbox-background-bg-opacity: 0.85;
9295

9396
$settings-grey-fg-color: #a2a2a2;
94-
$settings-profile-placeholder-bg-color: #21262c;
97+
$settings-profile-placeholder-bg-color: $system-dark;
9598
$settings-profile-overlay-placeholder-fg-color: #454545;
9699
$settings-profile-button-bg-color: #e7e7e7;
97100
$settings-profile-button-fg-color: $settings-profile-overlay-placeholder-fg-color;
@@ -175,7 +178,7 @@ $button-link-bg-color: transparent;
175178
$togglesw-off-color: $room-highlight-color;
176179

177180
$progressbar-fg-color: $accent-color;
178-
$progressbar-bg-color: #21262c;
181+
$progressbar-bg-color: $system-dark;
179182

180183
$visual-bell-bg-color: #800;
181184

@@ -210,7 +213,7 @@ $user-tile-hover-bg-color: $header-panel-bg-color;
210213
$message-body-panel-fg-color: $secondary-fg-color;
211214
$message-body-panel-bg-color: #394049; // "Dark Tile"
212215
$message-body-panel-icon-fg-color: $secondary-fg-color;
213-
$message-body-panel-icon-bg-color: #21262C; // "System Dark"
216+
$message-body-panel-icon-bg-color: $system-dark; // "System Dark"
214217

215218
$voice-record-stop-border-color: $quaternary-fg-color;
216219
$voice-record-waveform-incomplete-fg-color: $quaternary-fg-color;
@@ -228,9 +231,9 @@ $groupFilterPanel-background-blur-amount: 30px;
228231
$composer-shadow-color: rgba(0, 0, 0, 0.28);
229232

230233
// Bubble tiles
231-
$eventbubble-self-bg: #143A34;
232-
$eventbubble-others-bg: #394049;
233-
$eventbubble-bg-hover: #433C23;
234+
$eventbubble-self-bg: #14322E;
235+
$eventbubble-others-bg: $event-selected-color;
236+
$eventbubble-bg-hover: #1C2026;
234237
$eventbubble-avatar-outline: $bg-color;
235238
$eventbubble-reply-color: #C1C6CD;
236239

res/themes/legacy-light/css/_legacy-light.scss

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,12 @@
88
/* Noto Color Emoji contains digits, in fixed-width, therefore causing
99
digits in flowed text to stand out.
1010
TODO: Consider putting all emoji fonts to the end rather than the front. */
11-
$font-family: Nunito, Twemoji, 'Apple Color Emoji', 'Segoe UI Emoji', Arial, Helvetica, Sans-Serif, 'Noto Color Emoji';
11+
$font-family: 'Nunito', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Arial', 'Helvetica', 'Sans-Serif', 'Noto Color Emoji';
1212

13-
$monospace-font-family: Inconsolata, Twemoji, 'Apple Color Emoji', 'Segoe UI Emoji', Courier, monospace, 'Noto Color Emoji';
13+
$monospace-font-family: 'Inconsolata', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Courier', 'monospace', 'Noto Color Emoji';
14+
15+
// Colors from Figma Compound https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=557%3A0
16+
$system-light: #F4F6FA;
1417

1518
// unified palette
1619
// try to use these colors when possible
@@ -179,7 +182,7 @@ $composer-e2e-icon-color: #91a1c0;
179182
$header-divider-color: #91a1c0;
180183

181184
// this probably shouldn't have it's own colour
182-
$voipcall-plinth-color: #F4F6FA;
185+
$voipcall-plinth-color: $system-light;
183186

184187
// ********************
185188

@@ -331,7 +334,7 @@ $user-tile-hover-bg-color: $header-panel-bg-color;
331334
$message-body-panel-fg-color: $secondary-fg-color;
332335
$message-body-panel-bg-color: #E3E8F0;
333336
$message-body-panel-icon-fg-color: $secondary-fg-color;
334-
$message-body-panel-icon-bg-color: #F4F6FA;
337+
$message-body-panel-icon-bg-color: $system-light;
335338

336339
// See non-legacy _light for variable information
337340
$voice-record-stop-symbol-color: #ff4b55;
@@ -348,9 +351,9 @@ $appearance-tab-border-color: $input-darker-bg-color;
348351
$composer-shadow-color: tranparent;
349352

350353
// Bubble tiles
351-
$eventbubble-self-bg: #F8FDFC;
352-
$eventbubble-others-bg: #F7F8F9;
353-
$eventbubble-bg-hover: rgb(242, 242, 242);
354+
$eventbubble-self-bg: #F0FBF8;
355+
$eventbubble-others-bg: $system-light;
356+
$eventbubble-bg-hover: #FAFBFD;
354357
$eventbubble-avatar-outline: #fff;
355358
$eventbubble-reply-color: #C1C6CD;
356359

@@ -390,7 +393,7 @@ $eventbubble-reply-color: #C1C6CD;
390393
@define-mixin mx_DialogButton_secondary {
391394
// flip colours for the secondary ones
392395
font-weight: 600;
393-
border: 1px solid $accent-color ! important;
396+
border: 1px solid $accent-color !important;
394397
color: $accent-color;
395398
background-color: $button-secondary-bg-color;
396399
}

res/themes/light/css/_light.scss

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,12 @@
88
/* Noto Color Emoji contains digits, in fixed-width, therefore causing
99
digits in flowed text to stand out.
1010
TODO: Consider putting all emoji fonts to the end rather than the front. */
11-
$font-family: Inter, Twemoji, 'Apple Color Emoji', 'Segoe UI Emoji', Arial, Helvetica, Sans-Serif, 'Noto Color Emoji';
11+
$font-family: 'Inter', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Arial', 'Helvetica', 'Sans-Serif', 'Noto Color Emoji';
1212

13-
$monospace-font-family: Inconsolata, Twemoji, 'Apple Color Emoji', 'Segoe UI Emoji', Courier, monospace, 'Noto Color Emoji';
13+
$monospace-font-family: 'Inconsolata', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Courier', 'monospace', 'Noto Color Emoji';
14+
15+
// Colors from Figma Compound https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=557%3A0
16+
$system-light: #F4F6FA;
1417

1518
// unified palette
1619
// try to use these colors when possible
@@ -138,7 +141,7 @@ $blockquote-bar-color: #ddd;
138141
$blockquote-fg-color: #777;
139142

140143
$settings-grey-fg-color: #a2a2a2;
141-
$settings-profile-placeholder-bg-color: #f4f6fa;
144+
$settings-profile-placeholder-bg-color: $system-light;
142145
$settings-profile-overlay-placeholder-fg-color: #2e2f32;
143146
$settings-profile-button-bg-color: #e7e7e7;
144147
$settings-profile-button-fg-color: $settings-profile-overlay-placeholder-fg-color;
@@ -168,7 +171,7 @@ $composer-e2e-icon-color: #91A1C0;
168171
$header-divider-color: #91A1C0;
169172

170173
// this probably shouldn't have it's own colour
171-
$voipcall-plinth-color: #F4F6FA;
174+
$voipcall-plinth-color: $system-light;
172175

173176
// ********************
174177

@@ -327,7 +330,7 @@ $user-tile-hover-bg-color: $header-panel-bg-color;
327330
$message-body-panel-fg-color: $secondary-fg-color;
328331
$message-body-panel-bg-color: #E3E8F0; // "Separator"
329332
$message-body-panel-icon-fg-color: $secondary-fg-color;
330-
$message-body-panel-icon-bg-color: #F4F6FA;
333+
$message-body-panel-icon-bg-color: $system-light;
331334

332335
// These two don't change between themes. They are the $warning-color, but we don't
333336
// want custom themes to affect them by accident.
@@ -350,9 +353,9 @@ $groupFilterPanel-background-blur-amount: 20px;
350353
$composer-shadow-color: rgba(0, 0, 0, 0.04);
351354

352355
// Bubble tiles
353-
$eventbubble-self-bg: #F8FDFC;
354-
$eventbubble-others-bg: #F7F8F9;
355-
$eventbubble-bg-hover: #FEFCF5;
356+
$eventbubble-self-bg: #F0FBF8;
357+
$eventbubble-others-bg: $system-light;
358+
$eventbubble-bg-hover: #FAFBFD;
356359
$eventbubble-avatar-outline: $primary-bg-color;
357360
$eventbubble-reply-color: #C1C6CD;
358361

@@ -392,7 +395,7 @@ $eventbubble-reply-color: #C1C6CD;
392395
@define-mixin mx_DialogButton_secondary {
393396
// flip colours for the secondary ones
394397
font-weight: 600;
395-
border: 1px solid $accent-color ! important;
398+
border: 1px solid $accent-color !important;
396399
color: $accent-color;
397400
background-color: $button-secondary-bg-color;
398401
}

0 commit comments

Comments
 (0)