Skip to content

Commit 59cc982

Browse files
mathuoclaude
andcommitted
fix: fix SystemJS boilerplate configs for all frameworks
- Add format: cjs to dockview-core/dockview package configs so SystemJS wraps CJS modules correctly - Add dockview-core as transitive dependency in React CDN map - Angular: match AG Grid's config exactly — TypeScript 4.4, tslib, no explicit format for fesm2022 .mjs, add Angular sub-path mappings (primitives/signals, common/http, platform-browser/animations) - Fix zone.js path (fesm2015/ not dist/) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent d99bbdf commit 59cc982

File tree

5 files changed

+26
-8
lines changed

5 files changed

+26
-8
lines changed

packages/docs/scripts/buildTemplates.mjs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,11 @@ const FRAMEWORK_BOILERPLATE = {
2929
const DOCKVIEW_CDN = {
3030
react: {
3131
remote: {
32+
'dockview-core': `https://cdn.jsdelivr.net/npm/dockview-core@${DOCKVIEW_VERSION}`,
3233
dockview: `https://cdn.jsdelivr.net/npm/dockview@${DOCKVIEW_VERSION}`,
3334
},
3435
local: {
36+
'dockview-core': `${local}/dockview-core`,
3537
dockview: `${local}/dockview`,
3638
},
3739
},

packages/docs/static/example-runner/dockview-angular-boilerplate/systemjs.config.js

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,9 @@
1313
System.config({
1414
transpiler: 'ts',
1515
typescriptOptions: {
16-
target: 'es2015',
17-
module: 'system',
18-
moduleResolution: 'node',
19-
experimentalDecorators: true,
16+
target: 'es2020',
2017
emitDecoratorMetadata: true,
18+
experimentalDecorators: true,
2119
},
2220
meta: {
2321
typescript: {
@@ -32,38 +30,47 @@
3230
{
3331
css: '/example-runner/css.js',
3432
ts: 'npm:plugin-typescript@8.0.0/lib/plugin.js',
35-
typescript: 'npm:typescript@5.4.5/lib/typescript.min.js',
33+
tslib: 'npm:tslib@2.3.1/tslib.js',
34+
typescript: 'npm:typescript@4.4/lib/typescript.min.js',
3635

3736
app: defined_dockview_appLocation,
3837

3938
'@angular/core':
4039
'npm:@angular/core@17.0.0/fesm2022/core.mjs',
40+
'@angular/core/primitives/signals':
41+
'npm:@angular/core@17.0.0/fesm2022/primitives/signals.mjs',
4142
'@angular/common':
4243
'npm:@angular/common@17.0.0/fesm2022/common.mjs',
44+
'@angular/common/http':
45+
'npm:@angular/common@17.0.0/fesm2022/http.mjs',
4346
'@angular/compiler':
4447
'npm:@angular/compiler@17.0.0/fesm2022/compiler.mjs',
4548
'@angular/platform-browser':
4649
'npm:@angular/platform-browser@17.0.0/fesm2022/platform-browser.mjs',
50+
'@angular/platform-browser/animations':
51+
'npm:@angular/platform-browser@17.0.0/fesm2022/animations.mjs',
4752
'@angular/platform-browser-dynamic':
4853
'npm:@angular/platform-browser-dynamic@17.0.0/fesm2022/platform-browser-dynamic.mjs',
4954
rxjs: 'npm:rxjs@7.8.1/dist/bundles/rxjs.umd.min.js',
5055
'rxjs/operators':
5156
'npm:rxjs@7.8.1/dist/bundles/rxjs.umd.min.js',
52-
'zone.js': 'npm:zone.js@0.14.3/dist/zone.min.js',
57+
'zone.js': 'npm:zone.js@0.14.3/fesm2015/zone.min.js',
5358
},
5459
defined_dockview_systemJsMap
5560
),
5661
packages: {
62+
css: {},
5763
app: {
5864
defaultExtension: 'ts',
5965
},
6066
'dockview-core': {
6167
main: './dist/cjs/index.js',
68+
format: 'cjs',
6269
defaultExtension: 'js',
6370
},
6471
'dockview-angular': {
65-
main: './dist/cjs/index.js',
66-
defaultExtension: 'js',
72+
main: './dist/fesm2022/dockview-angular.mjs',
73+
defaultExtension: 'mjs',
6774
},
6875
},
6976
});

packages/docs/static/example-runner/dockview-react-boilerplate/systemjs.config.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,14 @@
4646
app: {
4747
defaultExtension: 'tsx',
4848
},
49+
'dockview-core': {
50+
main: './dist/cjs/index.js',
51+
format: 'cjs',
52+
defaultExtension: 'js',
53+
},
4954
dockview: {
5055
main: './dist/cjs/index.js',
56+
format: 'cjs',
5157
defaultExtension: 'js',
5258
},
5359
},

packages/docs/static/example-runner/dockview-typescript-boilerplate/systemjs.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
},
4242
'dockview-core': {
4343
main: './dist/cjs/index.js',
44+
format: 'cjs',
4445
defaultExtension: 'js',
4546
},
4647
},

packages/docs/static/example-runner/dockview-vue-boilerplate/systemjs.config.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,12 @@
4545
},
4646
'dockview-core': {
4747
main: './dist/cjs/index.js',
48+
format: 'cjs',
4849
defaultExtension: 'js',
4950
},
5051
'dockview-vue': {
5152
main: './dist/dockview-vue.es.js',
53+
format: 'esm',
5254
defaultExtension: 'js',
5355
},
5456
},

0 commit comments

Comments
 (0)