Skip to content

Conversation

@ambar
Copy link
Contributor

@ambar ambar commented Sep 3, 2017

No description provided.

@pkra pkra changed the base branch from master to develop September 5, 2017 09:17
@pkra pkra changed the base branch from develop to master September 5, 2017 09:18
@pkra
Copy link
Contributor

pkra commented Sep 5, 2017

Thanks for the PR.

Please note that PRs must be based on the develop branch (not master).

You also might want to add some comments on what you are trying to do. (I'm guessing this is for #299?)

@ambar ambar changed the base branch from master to develop September 5, 2017 09:27
@ambar
Copy link
Contributor Author

ambar commented Sep 5, 2017

@pkra rebased!

@pkra pkra added this to the 2.7.1 milestone Sep 5, 2017
@ambar
Copy link
Contributor Author

ambar commented Sep 5, 2017

I tried to use Puppeteer(https://github.com/ambar/puptex) before I found this workaround, do you think it's worth?

@pkra
Copy link
Contributor

pkra commented Sep 5, 2017

@ambar a fix for #299 would be great (and should have better overall performance than spinning up puppeteer/Chrome). But @dpvc will have to comment on the approach you're taking.

@pkra pkra removed this from the 2.7.1 milestone Sep 5, 2017
@ambar
Copy link
Contributor Author

ambar commented Sep 5, 2017

@pkra Thanks!

@dpvc
Copy link
Member

dpvc commented Sep 16, 2017

@pkra, I'm OK with the change, if you want to merge it.

@pkra
Copy link
Contributor

pkra commented Sep 17, 2017

Thanks. I just have not got around to it -- the pending bug fix release needs to be wrapped up before we merge.

@pkra
Copy link
Contributor

pkra commented Nov 2, 2017

Sorry for taking so long to come back to this.

We're ok with merging as is.

(We thought about adding an option to customize widths of halfwidth forms but that can be done later.)

@pkra pkra changed the title fix full-width characters rendering improve full-width characters rendering Nov 2, 2017
@pkra pkra merged commit 1113634 into mathjax:develop Nov 2, 2017
@pkra pkra added this to the 1.3.0 milestone Nov 2, 2017
@pkra
Copy link
Contributor

pkra commented Nov 10, 2017

I'm wondering if we should generalize this using https://github.com/sindresorhus/string-width. I'll make a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants