-
Notifications
You must be signed in to change notification settings - Fork 99
improve full-width characters rendering #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR. Please note that PRs must be based on the You also might want to add some comments on what you are trying to do. (I'm guessing this is for #299?) |
|
@pkra rebased! |
|
I tried to use Puppeteer(https://github.com/ambar/puptex) before I found this workaround, do you think it's worth? |
|
@pkra Thanks! |
|
@pkra, I'm OK with the change, if you want to merge it. |
|
Thanks. I just have not got around to it -- the pending bug fix release needs to be wrapped up before we merge. |
|
Sorry for taking so long to come back to this. We're ok with merging as is. (We thought about adding an option to customize widths of halfwidth forms but that can be done later.) |
|
I'm wondering if we should generalize this using https://github.com/sindresorhus/string-width. I'll make a new issue. |
No description provided.