Fix: resolve some project warnings (#1496)

* Remove CGSize conformance to Hashable, already provided by CoreGraphics

* Fix APIService concurrency warnings by adding MainActor annotations to some extensions

* Fix unused variable reference warning

* Update to UNUserNotificationCenter to set badge count, replacing deprecated UIApplication call

* Remove unused reference to self in SettingsService.init closure

* Fix concurrency warning by adding MainActor annotation to AutoCompleteViewModel.State subclass

* Fix concurrency warnings by removing await annotation for non-async functions in AutoCompleteViewModel+State

Author: aokj4ck

MastodonSDK/Sources/MastodonCore/Service/API/APIService+Bookmark.swift

@@ -58,7 +58,7 @@ extension APIService {
 
 }
 
-extension APIService {
+@MainActor extension APIService {
     public func bookmarkedStatuses(
         limit: Int = onceRequestStatusMaxCount,
         maxID: String? = nil,

MastodonSDK/Sources/MastodonCore/Service/API/APIService+Favorite.swift

@@ -100,7 +100,7 @@ extension APIService {
     }
 }
 
-extension APIService {
+@MainActor extension APIService {
     public func favoritedStatuses(
         limit: Int = onceRequestStatusMaxCount,
         maxID: String? = nil,

MastodonSDK/Sources/MastodonCore/Service/API/APIService+HashtagTimeline.swift

@@ -11,7 +11,7 @@ import CoreData
 import CoreDataStack
 import MastodonSDK
 
-extension APIService {
+@MainActor extension APIService {
 
     public func hashtagTimeline(
         sinceID: Mastodon.Entity.Status.ID? = nil,

MastodonSDK/Sources/MastodonCore/Service/API/APIService+HomeTimeline.swift

@@ -15,7 +15,7 @@ public extension Notification.Name {
     static let userFetched = Notification.Name(rawValue: "org.joinmastodon.app.user-fetched")
 }
 
-extension APIService {
+@MainActor extension APIService {
 
     public func homeTimeline(
         itemsNoOlderThan sinceID: Mastodon.Entity.Status.ID? = nil,

MastodonSDK/Sources/MastodonCore/Service/API/APIService+Status.swift

@@ -62,7 +62,6 @@ extension APIService {
     ) async throws -> Mastodon.Entity.Status {
         let authorization = authenticationBox.userAuthorization
 
-        let managedObjectContext = backgroundManagedObjectContext
         let _query: Mastodon.API.Statuses.DeleteStatusQuery? = Mastodon.API.Statuses.DeleteStatusQuery(id: postID)
         guard let query = _query else {
             throw APIError.implicit(.badRequest)

MastodonSDK/Sources/MastodonCore/Service/Notification/NotificationService.swift

@@ -104,7 +104,7 @@ public final class NotificationService {
             }
 
             UserDefaults.shared.notificationBadgeCount = count
-            UIApplication.shared.applicationIconBadgeNumber = count
+            UNUserNotificationCenter.current().setBadgeCount(count)
             Task { @MainActor in
                 UIApplication.shared.shortcutItems = try? await self.unreadApplicationShortcutItems()
             }

MastodonSDK/Sources/MastodonCore/Service/SettingService.swift

@@ -33,9 +33,7 @@ public final class SettingService {
 
         // create setting (if non-exist) for authenticated users
         AuthenticationServiceProvider.shared.$mastodonAuthenticationBoxes
-            .compactMap { [weak self] mastodonAuthenticationBoxes -> AnyPublisher<[MastodonAuthenticationBox], Never>? in
-                guard let self = self else { return nil }
-                
+            .compactMap { mastodonAuthenticationBoxes -> AnyPublisher<[MastodonAuthenticationBox], Never>? in
                 let managedObjectContext = PersistenceManager.shared.backgroundManagedObjectContext
                 return managedObjectContext.performChanges {
                     for authenticationBox in mastodonAuthenticationBoxes {

MastodonSDK/Sources/MastodonUI/Extension/CGSize+Hashable.swift

@@ -29,7 +29,7 @@ extension AutoCompleteViewModel {
 }
 
 extension AutoCompleteViewModel.State {
-    class Initial: AutoCompleteViewModel.State {
+    @MainActor class Initial: AutoCompleteViewModel.State {
         override func isValidNextState(_ stateClass: AnyClass) -> Bool {
             guard let viewModel = viewModel else { return false }
             switch stateClass {
@@ -84,17 +84,17 @@ extension AutoCompleteViewModel.State {
 
         private func fetchLocalEmoji(searchText: String) async {
             guard let viewModel = viewModel else {
-                await enter(state: Fail.self)
+                enter(state: Fail.self)
                 return
             }
 
             guard let customEmojiViewModel = viewModel.customEmojiViewModel else {
-                await enter(state: Fail.self)
+                enter(state: Fail.self)
                 return
             }
 
             guard let emojiTrie = customEmojiViewModel.emojiTrie.value else {
-                await enter(state: Fail.self)
+                enter(state: Fail.self)
                 return
             }
 
@@ -108,13 +108,13 @@ extension AutoCompleteViewModel.State {
                 AutoCompleteItem.emoji(emoji: emoji)
             }
 
-            await enter(state: Idle.self)
+            enter(state: Idle.self)
             viewModel.autoCompleteItems.value = items
         }
 
         private func queryRemoteEnitity(searchText: String) async {
             guard let viewModel = viewModel else {
-                await enter(state: Fail.self)
+                enter(state: Fail.self)
                 return
             }
 
@@ -136,7 +136,7 @@ extension AutoCompleteViewModel.State {
                     authenticationBox: viewModel.authenticationBox
                 )
 
-                await enter(state: Idle.self)
+                enter(state: Idle.self)
 
                 guard viewModel.inputText.value == searchText else { return }     // discard if not matching
 
@@ -147,7 +147,7 @@ extension AutoCompleteViewModel.State {
                 viewModel.autoCompleteItems.value = items
 
             } catch {
-                await enter(state: Fail.self)
+                enter(state: Fail.self)
             }
         }