Skip to content

Conversation

@williamboman
Copy link
Member

@williamboman williamboman commented Aug 2, 2025

Previously this field had to be handled separately in each source type
(currently only supported by cargo, gem, pypi). This
backwards-compatible change makes supported_platforms a universal
top-level field on the source: object, meaning it'll be parsed for
each source type.

PR to modify the schema: mason-org/registry-schema#17.

Previously this field had to be handled separately in each source type.
This backwards-compatible change makes `supported_platforms` a universal
top-level field on the `source:` object, meaning it'll be parsed for
each source type.
@chrisgrieser
Copy link
Member

chrisgrieser commented Aug 2, 2025

While you are at it: this PR revealed a tangentially related problem, regarding support for less popular platforms (freebsd), in case it's an easy fix that you can just tack on?

Copy link

@Conarius Conarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Conarius
Copy link

Conarius commented Aug 2, 2025

While you are at it: this PR revealed a tangentially related problem, regarding support for less popular platforms (freebsd), in case it's an easy fix that you can just tack on?

I think for that issue we would just have to setup CI tests on the mason-registry side mainly and adjust the enum of platforms and targets. Idk about the side of mason.nvim itself though.

@williamboman
Copy link
Member Author

While you are at it: this PR revealed a tangentially related problem, regarding support for less popular platforms (freebsd), in case it's an easy fix that you can just tack on?

I don't have access to a FreeBSD system so I can't really test and verify how to best do the platform detection. It's probably sufficient to rely on libuv's uv_os_uname(), similar to OpenBSD, but I'd need someone to verify.

I think for that issue we would just have to setup CI tests on the mason-registry side mainly and adjust the enum of platforms and targets. Idk about the side of mason.nvim itself though.

Ultimately it'd have to be implemented in the mason.nvim client as well. The registry and the client are decoupled, we could "easily" add FreeBSD support to the registry, then it's just a matter for the client to recognize that platform.

@williamboman williamboman merged commit 7dc4fac into main Aug 7, 2025
10 checks passed
@williamboman williamboman deleted the feat/supported-platform-universal-field branch August 7, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants