refactor: remove unused getter api from serializer

Author: DylanPiercey

packages/runtime-tags/src/__tests__/serializer.test.ts

@@ -1,12 +1,7 @@
 import assert from "node:assert/strict";
 import { inspect } from "node:util";
 
-import {
-  register,
-  registerGetter,
-  Serializer,
-  stringify,
-} from "../html/serializer";
+import { register, Serializer, stringify } from "../html/serializer";
 import type { Boundary } from "../html/writer";
 
 describe("serializer", () => {
@@ -889,15 +884,6 @@ describe("serializer", () => {
         },
       );
     });
-
-    it("getter", () => {
-      const scope = { value: 1 } as any;
-      const fn = () => scope.value;
-      fn.toString = () => "()=>s.value";
-      const obj = { a: 1, fn };
-      registerGetter("value", fn, scope);
-      assertStringify(obj, `{a:1,fn:(s=>()=>s.value)(_.a={value:1})}`);
-    });
   });
 
   describe("serializer", () => {

packages/runtime-tags/src/html/serializer.ts

@@ -11,7 +11,6 @@ interface Registered {
   id: string;
   access: string;
   scope: unknown;
-  getter: boolean;
 }
 
 enum MutationType {
@@ -398,21 +397,6 @@ export function register<T extends WeakKey>(
     id,
     scope,
     access: "_._" + toAccess(toObjectKey(id)),
-    getter: false,
-  });
-  return val;
-}
-
-export function registerGetter<T extends WeakKey>(
-  accessor: string,
-  val: T,
-  scope?: unknown,
-) {
-  REGISTRY.set(val, {
-    id: "",
-    scope,
-    access: toAccess(accessor),
-    getter: true,
   });
   return val;
 }
@@ -649,7 +633,7 @@ function writeRegistered(
   val: WeakKey,
   parent: Reference | null,
   accessor: string,
-  { access, scope, getter }: Registered,
+  { access, scope }: Registered,
 ) {
   if (scope) {
     const scopeRef = state.refs.get(scope);
@@ -661,21 +645,6 @@ function writeRegistered(
     );
     state.refs.set(val, fnRef);
 
-    if (getter) {
-      if (scopeRef) {
-        state.buf.push("()=>" + ensureId(state, scopeRef) + access);
-        return true;
-      }
-
-      state.buf.push("(s=>()=>s" + access + ")(");
-      writeProp(state, scope, parent, "");
-      state.buf.push(")");
-
-      const newScopeRef = state.refs.get(scope);
-      if (newScopeRef) ensureId(state, newScopeRef);
-      return true;
-    }
-
     if (scopeRef) {
       if (
         parent &&

packages/runtime-tags/src/html/writer.ts

@@ -135,6 +135,7 @@ export function _var(
   registryId: string,
 ) {
   _scope_with_id(parentScopeId)[scopeOffsetAccessor] = _scope_id();
+  // TODO: if the return value is already registered, use that.
   _scope_with_id(childScopeId)[AccessorProp.TagVariable] = _resume(
     {},
     registryId,