examples: refactor to adapt windows os and nitpick comments

Author: yuehaii

examples/roots_client/main.go

@@ -8,6 +8,7 @@ import (
 	"os"
 	"os/signal"
 	"path/filepath"
+	"strings"
 	"syscall"
 
 	"github.com/mark3labs/mcp-go/client"
@@ -19,6 +20,7 @@ import (
 // In a real implementation, this would enumerate workspace/project roots.
 type MockRootsHandler struct{}
 
+// ListRoots implements client.RootsHandler by returning example workspace roots.
 func (h *MockRootsHandler) ListRoots(ctx context.Context, request mcp.ListRootsRequest) (*mcp.ListRootsResult, error) {
 	home, err := os.UserHomeDir()
 	if err != nil {
@@ -31,17 +33,26 @@ func (h *MockRootsHandler) ListRoots(ctx context.Context, request mcp.ListRootsR
 		Roots: []mcp.Root{
 			{
 				Name: "app",
-				URI:  (&url.URL{Scheme: "file", Path: app}).String(),
+				URI:  h.fileURI(app),
 			},
 			{
 				Name: "test-project",
-				URI:  (&url.URL{Scheme: "file", Path: proj}).String(),
+				URI:  h.fileURI(proj),
 			},
 		},
 	}
 	return result, nil
 }
 
+// fileURI returns a file:// URI for both Unix and Windows absolute paths.
+func (h *MockRootsHandler) fileURI(p string) string {
+	p = filepath.ToSlash(p)
+	if !strings.HasPrefix(p, "/") { // e.g., "C:/Users/..." on Windows
+		p = "/" + p
+	}
+	return (&url.URL{Scheme: "file", Path: p}).String()
+}
+
 // main starts a mock MCP roots client that communicates with a subprocess over stdio.
 // It expects the server command as the first command-line argument, creates a stdio
 // transport and an MCP client with a MockRootsHandler, starts and initializes the
@@ -133,8 +144,11 @@ func main() {
 	} else if len(result.Content) > 0 {
 		resultStr := ""
 		for _, content := range result.Content {
-			if textContent, ok := content.(mcp.TextContent); ok {
-				resultStr += fmt.Sprintf("%s\n", textContent.Text)
+			switch tc := content.(type) {
+			case mcp.TextContent:
+				resultStr += fmt.Sprintf("%s\n", tc.Text)
+			case *mcp.TextContent:
+				resultStr += fmt.Sprintf("%s\n", tc.Text)
 			}
 		}
 		fmt.Printf("client call tool result: %s\n", resultStr)

examples/roots_http_client/main.go

@@ -8,6 +8,7 @@ import (
 	"os"
 	"os/signal"
 	"path/filepath"
+	"strings"
 	"syscall"
 
 	"github.com/mark3labs/mcp-go/client"
@@ -19,6 +20,7 @@ import (
 // In a real implementation, this would enumerate workspace/project roots.
 type MockRootsHandler struct{}
 
+// ListRoots implements client.RootsHandler by returning example workspace roots.
 func (h *MockRootsHandler) ListRoots(ctx context.Context, request mcp.ListRootsRequest) (*mcp.ListRootsResult, error) {
 	home, err := os.UserHomeDir()
 	if err != nil {
@@ -31,17 +33,26 @@ func (h *MockRootsHandler) ListRoots(ctx context.Context, request mcp.ListRootsR
 		Roots: []mcp.Root{
 			{
 				Name: "app",
-				URI:  (&url.URL{Scheme: "file", Path: app}).String(),
+				URI:  h.fileURI(app),
 			},
 			{
 				Name: "test-project",
-				URI:  (&url.URL{Scheme: "file", Path: proj}).String(),
+				URI:  h.fileURI(proj),
 			},
 		},
 	}
 	return result, nil
 }
 
+// fileURI returns a file:// URI for both Unix and Windows absolute paths.
+func (h *MockRootsHandler) fileURI(p string) string {
+	p = filepath.ToSlash(p)
+	if !strings.HasPrefix(p, "/") { // e.g., "C:/Users/..." on Windows
+		p = "/" + p
+	}
+	return (&url.URL{Scheme: "file", Path: p}).String()
+}
+
 // main starts a mock MCP roots client over HTTP.
 // The server tool triggers a roots/list request on the client.
 // The client shuts down gracefully on SIGINT or SIGTERM.
@@ -57,7 +68,6 @@ func main() {
 	if err != nil {
 		log.Fatalf("Failed to create HTTP transport: %v", err)
 	}
-	defer httpTransport.Close()
 
 	// Create client with roots support
 	mcpClient := client.NewClient(
@@ -123,24 +133,19 @@ func main() {
 	} else if len(result.Content) > 0 {
 		resultStr := ""
 		for _, content := range result.Content {
-			if textContent, ok := content.(mcp.TextContent); ok {
-				resultStr += fmt.Sprintf("%s\n", textContent.Text)
+			switch tc := content.(type) {
+			case mcp.TextContent:
+				resultStr += fmt.Sprintf("%s\n", tc.Text)
+			case *mcp.TextContent:
+				resultStr += fmt.Sprintf("%s\n", tc.Text)
 			}
 		}
 		fmt.Printf("client call tool result: %s\n", resultStr)
 	}
 
 	// Keep the client running (in a real app, you'd have your main application logic here)
-	sigChan := make(chan os.Signal, 1)
-	signal.Notify(sigChan, os.Interrupt, syscall.SIGTERM)
-
-	shutdownCtx, cancel := context.WithCancel(ctx)
-	defer cancel()
-
-	go func() {
-		<-sigChan
-		log.Println("Received shutdown signal")
-		cancel()
-	}()
-	<-shutdownCtx.Done()
+	waitCtx, stop := signal.NotifyContext(ctx, os.Interrupt, syscall.SIGTERM)
+	defer stop()
+	<-waitCtx.Done()
+	log.Println("Received shutdown signal")
 }

examples/roots_server/main.go

@@ -33,15 +33,10 @@ func main() {
 	// Add a simple tool to test roots list
 	mcpServer.AddTool(mcp.Tool{
 		Name:        "roots",
-		Description: "list root result",
+		Description: "Returns the current list of roots from the server",
 		InputSchema: mcp.ToolInputSchema{
-			Type: "object",
-			Properties: map[string]any{
-				"testonly": map[string]any{
-					"type":        "string",
-					"description": "is this test only?",
-				},
-			},
+			Type:       "object",
+			Properties: map[string]any{},
 		},
 	}, func(ctx context.Context, request mcp.CallToolRequest) (*mcp.CallToolResult, error) {
 		rootRequest := mcp.ListRootsRequest{}
@@ -64,7 +59,7 @@ func main() {
 				Content: []mcp.Content{
 					mcp.TextContent{
 						Type: "text",
-						Text: fmt.Sprintf("Fail to list roots: %v", err),
+						Text: fmt.Sprintf("Failed to list roots: %v", err),
 					},
 				},
 				IsError: true,