Merge pull request #3 from mariofusco/d1025mf

[DROOLS-1025] minor perf optimization

Author: mdproctor

drools-core/src/main/java/org/drools/core/impl/KnowledgeBaseImpl.java

@@ -1410,11 +1410,13 @@ public void registerSegmentPrototype(LeftTupleSource tupleSource, SegmentMemory
     }
 
     public void invalidateSegmentPrototype(LeftTupleNode tupleSource, boolean ruleRemoved) {
-        if (ruleRemoved && tupleSource.getAssociationsSize() < 2) {
+        if (segmentProtos.isEmpty() || (ruleRemoved && tupleSource.getAssociationsSize() < 2)) {
             return;
         }
-        while ( tupleSource.getLeftTupleSource() != null ) {
-            tupleSource = tupleSource.getLeftTupleSource();
+        if (ruleRemoved) {
+            while ( tupleSource.getLeftTupleSource() != null ) {
+                tupleSource = tupleSource.getLeftTupleSource();
+            }
         }
         internalInvalidateSegmentPrototype(tupleSource);
     }

drools-core/src/main/java/org/drools/core/phreak/AddRemoveRule.java

@@ -68,6 +68,10 @@ public static void addRule(TerminalNode tn, InternalWorkingMemory[] wms, Interna
         // TODO Can this be made lighter, do we need to iterate up to tip.
         kBase.invalidateSegmentPrototype(firstSplit, false);
 
+        if (wms.length == 0) {
+            return;
+        }
+
         PathEndNodes pathEndNodes = getPathEndNodes((LeftTupleSource) firstSplit, tn, null);
 
         // Insert the facts for the new paths. This will iterate each new path from EndNode to the splitStart - but will not process the splitStart itself (as tha already exist).
@@ -232,6 +236,10 @@ public static void removeRule(TerminalNode tn, InternalWorkingMemory[] wms, Inte
         // TODO Can this be made lighter, do we need to iterate up to tip.
         kBase.invalidateSegmentPrototype(firstSplit, false);
 
+        if (wms.length == 0) {
+            return;
+        }
+
         PathEndNodes pathEndNodes = getPathEndNodes((LeftTupleSource) firstSplit, tn, null);
 
         for (InternalWorkingMemory wm : wms) {

drools-core/src/main/java/org/drools/core/phreak/SegmentUtilities.java

@@ -433,7 +433,7 @@ private static int updateRiaAndTerminalMemory( LeftTupleSource lt,
     }
 
     private static int checkSegmentBoundary(LeftTupleSource lt, InternalWorkingMemory wm, int nodeTypesInSegment) {
-        if ( !isRootNode( lt, null ) )  {
+        if ( isRootNode( lt, null ) )  {
             // we are in a new child segment
             checkEagerSegmentCreation(lt.getLeftTupleSource(), wm, nodeTypesInSegment);
             nodeTypesInSegment = 0;