From 57eff9e2300aa9ed733660beed0b8406e86ecc3b Mon Sep 17 00:00:00 2001 From: koaning Date: Mon, 21 Jul 2025 14:18:57 +0200 Subject: [PATCH 1/6] Please provide the git diff for review. --- .../editor/actions/useNotebookActions.tsx | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/frontend/src/components/editor/actions/useNotebookActions.tsx b/frontend/src/components/editor/actions/useNotebookActions.tsx index da860519efd..2f0ee4f647a 100644 --- a/frontend/src/components/editor/actions/useNotebookActions.tsx +++ b/frontend/src/components/editor/actions/useNotebookActions.tsx @@ -35,6 +35,7 @@ import { PresentationIcon, SettingsIcon, Share2Icon, + TextSearchIcon, Undo2Icon, XCircleIcon, YoutubeIcon, @@ -286,6 +287,12 @@ export function useNotebookActions() { }; }), }, + { + icon: , + label: "View live docs", + description: "Show the documentation helper panel", + handle: () => toggleApplication("documentation"), + }, { icon: , @@ -543,6 +550,12 @@ export function useNotebookActions() { variant: "danger", handle: restartKernel, }, + { + icon: , + label: "Helper panel > Chat with AI", + description: "Chat with AI assistant", + handle: () => toggleApplication("chat"), + }, ]; return actions From 053fb04773bd0af598bc47e7d11c2cc59add4b91 Mon Sep 17 00:00:00 2001 From: koaning Date: Mon, 21 Jul 2025 14:20:17 +0200 Subject: [PATCH 2/6] Sure! Please provide the git diff you'd like me to summarize, and I'll help you craft a concise commit message. --- frontend/src/components/editor/actions/useNotebookActions.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/components/editor/actions/useNotebookActions.tsx b/frontend/src/components/editor/actions/useNotebookActions.tsx index 2f0ee4f647a..ae876a685d5 100644 --- a/frontend/src/components/editor/actions/useNotebookActions.tsx +++ b/frontend/src/components/editor/actions/useNotebookActions.tsx @@ -289,7 +289,7 @@ export function useNotebookActions() { }, { icon: , - label: "View live docs", + label: "Helper panel > View live docs", description: "Show the documentation helper panel", handle: () => toggleApplication("documentation"), }, From 5d2bc930da9a4952346c26246a521f53ccb94dac Mon Sep 17 00:00:00 2001 From: Shahmir Varqha Date: Sat, 26 Jul 2025 23:05:01 +0800 Subject: [PATCH 3/6] apply fix --- .../editor/actions/useNotebookActions.tsx | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/frontend/src/components/editor/actions/useNotebookActions.tsx b/frontend/src/components/editor/actions/useNotebookActions.tsx index ae876a685d5..78c09785eb7 100644 --- a/frontend/src/components/editor/actions/useNotebookActions.tsx +++ b/frontend/src/components/editor/actions/useNotebookActions.tsx @@ -35,7 +35,6 @@ import { PresentationIcon, SettingsIcon, Share2Icon, - TextSearchIcon, Undo2Icon, XCircleIcon, YoutubeIcon, @@ -275,24 +274,18 @@ export function useNotebookActions() { icon: , label: "Helper panel", handle: NOOP_HANDLER, - dropdown: PANELS.flatMap(({ type, Icon, hidden }) => { + dropdown: PANELS.flatMap(({ type, Icon, hidden, tooltip }) => { if (hidden) { return []; } return { - label: startCase(type), + label: startCase(tooltip), rightElement: renderCheckboxElement(selectedPanel === type), icon: , handle: () => toggleApplication(type), }; }), }, - { - icon: , - label: "Helper panel > View live docs", - description: "Show the documentation helper panel", - handle: () => toggleApplication("documentation"), - }, { icon: , @@ -550,12 +543,6 @@ export function useNotebookActions() { variant: "danger", handle: restartKernel, }, - { - icon: , - label: "Helper panel > Chat with AI", - description: "Chat with AI assistant", - handle: () => toggleApplication("chat"), - }, ]; return actions From deb12ee2540352e17ad4f6593a106d852bcad8bc Mon Sep 17 00:00:00 2001 From: koaning Date: Tue, 29 Jul 2025 15:57:52 +0200 Subject: [PATCH 4/6] an approach with extraDescription --- .../editor/actions/useNotebookActions.tsx | 11 +++++++---- frontend/src/components/editor/chrome/types.ts | 15 +++++++++++++++ 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/frontend/src/components/editor/actions/useNotebookActions.tsx b/frontend/src/components/editor/actions/useNotebookActions.tsx index 78c09785eb7..0e3942d406f 100644 --- a/frontend/src/components/editor/actions/useNotebookActions.tsx +++ b/frontend/src/components/editor/actions/useNotebookActions.tsx @@ -274,16 +274,19 @@ export function useNotebookActions() { icon: , label: "Helper panel", handle: NOOP_HANDLER, - dropdown: PANELS.flatMap(({ type, Icon, hidden, tooltip }) => { + dropdown: PANELS.flatMap(({ type, Icon, hidden, extraDescription }) => { if (hidden) { return []; } - return { - label: startCase(tooltip), + const descriptions = extraDescription + ? [...extraDescription, type] + : [type]; + return descriptions.map((description) => ({ + label: startCase(description), rightElement: renderCheckboxElement(selectedPanel === type), icon: , handle: () => toggleApplication(type), - }; + })); }), }, diff --git a/frontend/src/components/editor/chrome/types.ts b/frontend/src/components/editor/chrome/types.ts index 97436b6fd61..ac8e7a78fcc 100644 --- a/frontend/src/components/editor/chrome/types.ts +++ b/frontend/src/components/editor/chrome/types.ts @@ -41,6 +41,7 @@ export interface PanelDescriptor { hidden?: boolean; tooltip: string; position: "sidebar" | "footer"; + extraDescription?: string[]; } export const PANELS: PanelDescriptor[] = [ @@ -49,66 +50,77 @@ export const PANELS: PanelDescriptor[] = [ Icon: FolderTreeIcon, tooltip: "View files", position: "sidebar", + extraDescription: ["View files"], }, { type: "variables", Icon: FunctionSquareIcon, tooltip: "Explore variables", position: "sidebar", + extraDescription: ["Explore variables"], }, { type: "datasources", Icon: DatabaseIcon, tooltip: "Explore data sources", position: "sidebar", + extraDescription: ["Explore data sources", "data sources"], }, { type: "dependencies", Icon: NetworkIcon, tooltip: "Explore dependencies", position: "sidebar", + extraDescription: ["Explore dependencies"], }, { type: "packages", Icon: BoxIcon, tooltip: "Manage packages", position: "sidebar", + extraDescription: ["Manage packages", "requirements"], }, { type: "outline", Icon: ScrollTextIcon, tooltip: "View outline", position: "sidebar", + extraDescription: ["View outline", "Show chapter headings"], }, { type: "chat", Icon: BotMessageSquareIcon, tooltip: "Chat with AI", position: "sidebar", + extraDescription: ["Chat with AI", "AI chat"], }, { type: "documentation", Icon: TextSearchIcon, tooltip: "View live docs", position: "sidebar", + extraDescription: ["View live docs", "Show contextual help"], }, { type: "logs", Icon: FileTextIcon, tooltip: "Notebook logs", position: "sidebar", + extraDescription: ["Notebook logs"], }, { type: "tracing", Icon: ActivityIcon, tooltip: "Tracing", position: "sidebar", + extraDescription: ["Tracing"], }, { type: "snippets", Icon: SquareDashedBottomCodeIcon, tooltip: "Snippets", position: "sidebar", + extraDescription: ["Snippets"], }, { // Not supported in WebAssembly yet @@ -117,17 +129,20 @@ export const PANELS: PanelDescriptor[] = [ tooltip: "Secrets", hidden: isWasm(), position: "sidebar", + extraDescription: ["environment variables"], }, { type: "scratchpad", Icon: NotebookPenIcon, tooltip: "Scratchpad", position: "sidebar", + extraDescription: ["Scratchpad"], }, { type: "errors", Icon: XCircleIcon, tooltip: "View errors", position: "footer", + extraDescription: ["View errors"], }, ]; From 08868de6bbda33cd4be7013b647ae58d08ad4a38 Mon Sep 17 00:00:00 2001 From: koaning Date: Tue, 29 Jul 2025 15:59:56 +0200 Subject: [PATCH 5/6] slight rename --- frontend/src/components/editor/chrome/types.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/src/components/editor/chrome/types.ts b/frontend/src/components/editor/chrome/types.ts index ac8e7a78fcc..a9d9cc76c09 100644 --- a/frontend/src/components/editor/chrome/types.ts +++ b/frontend/src/components/editor/chrome/types.ts @@ -113,14 +113,14 @@ export const PANELS: PanelDescriptor[] = [ Icon: ActivityIcon, tooltip: "Tracing", position: "sidebar", - extraDescription: ["Tracing"], + extraDescription: ["Traces"], }, { type: "snippets", Icon: SquareDashedBottomCodeIcon, tooltip: "Snippets", position: "sidebar", - extraDescription: ["Snippets"], + extraDescription: ["Code snippets"], }, { // Not supported in WebAssembly yet @@ -129,14 +129,14 @@ export const PANELS: PanelDescriptor[] = [ tooltip: "Secrets", hidden: isWasm(), position: "sidebar", - extraDescription: ["environment variables"], + extraDescription: ["Environment variables"], }, { type: "scratchpad", Icon: NotebookPenIcon, tooltip: "Scratchpad", position: "sidebar", - extraDescription: ["Scratchpad"], + extraDescription: ["Notes"], }, { type: "errors", From 607a42f1ccd3f02bd1453222e75ef714c22cdd81 Mon Sep 17 00:00:00 2001 From: koaning Date: Tue, 29 Jul 2025 16:12:06 +0200 Subject: [PATCH 6/6] signature feels like a good word --- frontend/src/components/editor/chrome/types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/components/editor/chrome/types.ts b/frontend/src/components/editor/chrome/types.ts index a9d9cc76c09..008d4772063 100644 --- a/frontend/src/components/editor/chrome/types.ts +++ b/frontend/src/components/editor/chrome/types.ts @@ -99,7 +99,7 @@ export const PANELS: PanelDescriptor[] = [ Icon: TextSearchIcon, tooltip: "View live docs", position: "sidebar", - extraDescription: ["View live docs", "Show contextual help"], + extraDescription: ["View live docs", "Show contextual help", "Signature"], }, { type: "logs",