release sql mode and update docs (#6666)

Light2Dark · web-flow · commit 40fe4926318f · 2025-10-03T17:13:18.000-04:00
## 📝 Summary  By default works for internal duckdb engine so is safe for release. Some docs update too: <img src="https://github.com/user-attachments/assets/dcbd9916-0db0-4074-a147-727a797f0576" width="600" /> ## 🔍 Description of Changes  ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected.
diff --git a/docs/_static/docs-sql-format-icon.webp b/docs/_static/docs-sql-format-icon.webp
diff --git a/docs/_static/docs-sql-linter.webp b/docs/_static/docs-sql-linter.webp
diff --git a/docs/_static/docs-sql-validate-mode.mp4 b/docs/_static/docs-sql-validate-mode.mp4
diff --git a/docs/guides/debugging.md b/docs/guides/debugging.md
@@ -11,7 +11,7 @@ step through the code, and evaluate expressions.
 
 Here's an example of how to use `breakpoint()` in a marimo notebook cell.
 
-![PDB in marimo](/_static/docs-pdb-demo.png)
+![PDB in marimo](../_static/docs-pdb-demo.png)
 
 Type `help` in the debugger for a list of commands:
 
@@ -92,7 +92,7 @@ When interacting with the AI chat, you can reference the notebook "Errors" with
 the `@-symbol` to bring in comprehensive error information from your notebook,
 making it easier to get targeted debugging help.
 
-![Notebook Errors context in marimo](/_static/docs-notebook-errors-context.png)
+![Notebook Errors context in marimo](../_static/docs-notebook-errors-context.png)
 
 ### Best practices for AI-assisted debugging
 
diff --git a/docs/guides/editor_features/ai_completion.md b/docs/guides/editor_features/ai_completion.md
@@ -176,11 +176,11 @@ To set up Windsurf:
 2. Download the [Windsurf app](https://windsurf.com/download).
 3. After installing Windsurf and authenticating, open up the command palette, via <kbd>cmd</kbd>+<kbd>shift</kbd>+<kbd>p</kbd>, and ask it to copy the api key to your clipboard.
 
-![Copy Windsurf API key](/_static/windsurf-api.png)
+![Copy Windsurf API key](../../_static/windsurf-api.png)
 
 4a. Configure the UI settings in the editor to use Windsurf.
 
-![Paste Windsurf API key](/_static/windsurf-settings.png)
+![Paste Windsurf API key](../../_static/windsurf-settings.png)
 
 4b. Alternatively you can also configure the api key from the marimo config file.
 
diff --git a/docs/guides/working_with_data/sql.md b/docs/guides/working_with_data/sql.md
@@ -359,6 +359,44 @@ df = catalog.load_table(("my-namespace", "my-table")).to_polars()
 SUMMARIZE df;
 ```
 
+## Utilities
+
+marimo provides a few utilities when working with SQL
+
+**SQL Linter**
+
+Lint your SQL code and provide better autocompletions and error highlighting.
+
+<div align="center">
+  <figure>
+    <img width="600" src="/_static/docs-sql-linter.webp"/>
+  </figure>
+</div>
+
+To disable the linter, you can set the `sql_linter` configuration to `false` in your `pyproject.toml` file or disable it in the marimo editor's settings menu.
+
+**SQL Formatting**
+
+Click on the paint roller icon at the bottom right of the SQL cell to format your SQL code.
+
+<div align="center">
+  <figure>
+    <img width="300" src="/_static/docs-sql-format-icon.webp"/>
+  </figure>
+</div>
+
+**SQL Mode**
+
+For In-Memory DuckDB, marimo offers a Validate mode that will validate your SQL as you write it.
+
+<figure>
+<video autoplay muted loop playsinline width="600px" align="center">
+    <source src="/_static/docs-sql-validate-mode.mp4" type="video/mp4">
+</video>
+</figure>
+
+Under the hood, this runs a debounced query in EXPLAIN mode and returns the parsed errors.
+
 ## Interactive tutorial
 
 For an interactive tutorial, run
diff --git a/frontend/src/core/codemirror/language/languages/sql/sql.ts b/frontend/src/core/codemirror/language/languages/sql/sql.ts
@@ -26,7 +26,6 @@ import type {
   DiagnosticsConfig,
   LSPConfig,
 } from "@/core/config/config-schema";
-import { getFeatureFlag } from "@/core/config/feature-flag";
 import {
   dataSourceConnectionsAtom,
   setLatestEngineSelected,
@@ -88,11 +87,7 @@ export class SQLLanguageAdapter
   sqlModeEnabled: boolean;
 
   constructor() {
-    try {
-      this.sqlModeEnabled = getFeatureFlag("sql_mode");
-    } catch {
-      this.sqlModeEnabled = false;
-    }
+    this.sqlModeEnabled = true;
   }
 
   get defaultMetadata(): SQLLanguageAdapterMetadata {
diff --git a/frontend/src/core/codemirror/language/panel/panel.tsx b/frontend/src/core/codemirror/language/panel/panel.tsx
@@ -5,7 +5,6 @@ import { Button } from "@/components/ui/button";
 import { Checkbox } from "@/components/ui/checkbox";
 import { Tooltip, TooltipProvider } from "@/components/ui/tooltip";
 import { normalizeName } from "@/core/cells/names";
-import { getFeatureFlag } from "@/core/config/feature-flag";
 import { type ConnectionName, DUCKDB_ENGINE } from "@/core/datasets/engines";
 import { useAutoGrowInputProps } from "@/hooks/useAutoGrowInputProps";
 import { formatSQL } from "../../format";
@@ -71,8 +70,6 @@ export const LanguagePanelComponent: React.FC<{
       updateSQLDialectFromConnection(view, engine);
     };
 
-    const sqlModeEnabled = getFeatureFlag("sql_mode");
-
     actions = (
       <div className="flex flex-1 gap-2 items-center">
         <label className="flex gap-2 items-center">
@@ -98,9 +95,7 @@ export const LanguagePanelComponent: React.FC<{
           onChange={switchEngine}
         />
         <div className="flex items-center gap-2 ml-auto">
-          {sqlModeEnabled && metadata.engine === DUCKDB_ENGINE && (
-            <SQLModeSelect />
-          )}
+          {metadata.engine === DUCKDB_ENGINE && <SQLModeSelect />}
           <Tooltip content="Format SQL">
             <Button
               variant="text"
diff --git a/frontend/src/core/config/feature-flag.tsx b/frontend/src/core/config/feature-flag.tsx
@@ -12,7 +12,6 @@ export interface ExperimentalFeatures {
   performant_table_charts: boolean;
   chat_modes: boolean;
   external_agents: boolean;
-  sql_mode: boolean;
   // Add new feature flags here
 }
 
@@ -23,7 +22,6 @@ const defaultValues: ExperimentalFeatures = {
   performant_table_charts: false,
   chat_modes: false,
   external_agents: import.meta.env.DEV,
-  sql_mode: false,
 };
 
 export function getFeatureFlag<T extends keyof ExperimentalFeatures>(
diff --git a/marimo/_config/config.py b/marimo/_config/config.py
@@ -513,7 +513,6 @@ class ExperimentalConfig(TypedDict, total=False):
     rtc_v2: bool
     performant_table_charts: bool
     chat_modes: bool
-    sql_mode: bool
 
     # Internal features
     cache: CacheConfig
diff --git a/marimo/_server/print.py b/marimo/_server/print.py
@@ -149,6 +149,7 @@ def print_experimental_features(config: MarimoConfig) -> None:
         "setup_cell",
         "mcp_docs",
         "sql_linter",
+        "sql_mode",
     }
     keys = keys - finished_experiments
 
diff --git a/pyproject.toml b/pyproject.toml
@@ -544,7 +544,6 @@ format_on_save = true
 [tool.marimo.experimental]
 multi_column = true
 performant_table_charts = true
-sql_mode = true
 chat_modes = true
 
 [tool.marimo.display]
