Removed deprecated args to work with phantomjs 2 #129 #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Logged this error #151 Now I realise it is a duplicate & there is a PR. Is there an ETA on this fix getting accepted? |
|
It's a bummer this repo is getting ignored :( I would love to see this fix merged in. Any chance we could beg you to update it @marcelduran :) |
|
Top, thanks guys ! |
|
I've applied the PR, however even running something simple as "phantomjs yslow.js --help" just hangs forever returning no information back. At least I'm not getting an error now, but still not working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PhantomJS 2, the phantom.args has been removed, using system.args works instead.