Skip to content

Commit eb45907

Browse files
marc-hblgirdwood
authored andcommitted
checkpatch: --ignore C99_COMMENT_TOLERANCE
Let's not waste considerable time in code reviews with silly problems computers can solve. Signed-off-by: Marc Herbert <[email protected]>
1 parent fa38c34 commit eb45907

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.github/workflows/shallow_checkpatch.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,11 @@ jobs:
1919
runs-on: ubuntu-20.04
2020
env:
2121
PR_NUM: ${{github.event.number}}
22+
# TODO: reduce duplication with scripts/sof-*-commit-hook.sh
23+
# thanks to either some .conf file or some wrapper script
2224
CHK_CMD_OPTS: --ignore UNKNOWN_COMMIT_ID --codespell --codespellfile
2325
/usr/lib/python3/dist-packages/codespell_lib/data/dictionary.txt
26+
--ignore C99_COMMENT_TOLERANCE
2427
steps:
2528
# depth 2 so:
2629
# ^1. we can show the Subject of the current target branch tip

scripts/sof-post-commit-hook.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,8 @@
33
# Copyright(c) 2018 Intel Corporation. All rights reserved.
44

55
set -e
6-
exec git show --format=email HEAD | ./scripts/checkpatch.pl --no-tree --strict --codespell
6+
# TODO: reduce duplication with scripts/sof-pre-commit-hook.sh
7+
# and with .github/workflows/ with either some .conf file
8+
# or some wrapper script
9+
exec git show --format=email HEAD |
10+
./scripts/checkpatch.pl --no-tree --strict --codespell --ignore C99_COMMENT_TOLERANCE

0 commit comments

Comments
 (0)