Viewport #770
Merged
Viewport #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjleonard37
reviewed
Nov 18, 2024
| return makeCameraViewportState(camera: options.toCameraOptions()) | ||
| default: | ||
| throw ViewportInternalError( | ||
| code: "Could not create viewport state ouf of options \(stateStorage)", |
Contributor
There was a problem hiding this comment.
Suggested change
| code: "Could not create viewport state ouf of options \(stateStorage)", | |
| code: "Could not create viewport state out of options \(stateStorage)", |
pjleonard37
reviewed
Nov 19, 2024
pjleonard37
reviewed
Nov 20, 2024
pjleonard37
reviewed
Nov 20, 2024
pjleonard37
previously approved these changes
Dec 2, 2024
Contributor
pjleonard37
left a comment
pjleonard37
left a comment
There was a problem hiding this comment.
Looks good! Excited for this :)
Co-authored-by: Patrick Leonard <[email protected]>
pjleonard37
approved these changes
Dec 2, 2024
brandon-watkins-avcrm
pushed a commit
to brandon-watkins-avcrm/mapbox-maps-flutter
that referenced
this pull request
Mar 27, 2025
* Viewport draft * Simple map example * format * more viewport * declarative viewport draft * Declarative viewport on iOS and Android * Fix rebase issues * Docs, example + bug fix * add changelog entry * typo * Remove unused code * lint * lint * Fix en-/de- coding for CameraViewportState * Fix exception when converting CameraOptions for CameraViewportState on Android * Add note about location requirement for FollowPuckViewportState * Add tests for viewport states * lint * Update example/lib/viewport_example.dart Co-authored-by: Patrick Leonard <[email protected]> * Center camera over Disneyland in simple map example * Disable overview state viewport test on Android due to a bug * Update example/integration_test/viewport_test.dart Co-authored-by: Patrick Leonard <[email protected]> --------- Co-authored-by: Patrick Leonard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This pull request introduces viewport support to the MapWidget, allowing developers to control the camera’s initial position and behavior when displaying a map. By specifying a ViewportState subclass in the viewport parameter, developers can center the map on specific locations, follow the user’s position, or display an overview of a geometry.
What is the motivation and context behind this change?
https://mapbox.atlassian.net/browse/MAPSFLT-60
Pull request checklist: