Skip to content

Fix crash after creating/destroying multiple Snapshotters #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evil159 merged 2 commits into from
Oct 10, 2024
Merged

Fix crash after creating/destroying multiple Snapshotters #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7554be6
Fix crash after creating/destroying multiple Snapshotters
evil159 Oct 10, 2024
2102d9a
Add changelog entry
evil159 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ onCameraChangeListener(CameraChangedEventData data) {
```
* Print to console native Maps SDK logs in debug configuration.
Logs are proxied only in debug configuration and can be disabled completely by passing environment flag `MAPBOX_LOG_DEBUG` with false value.
* Fix rare crash in `Snapshotter`. The crash could happen when creating/destroying multiple instances of `Snapshotter` in succession.

# 2.3.0

Expand Down
2 changes: 1 addition & 1 deletion lib/src/snapshotter/snapshotter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ final class Snapshotter {
snapshotter._mapEvents.eventTypes.map((e) => e.index).toList(),
options);

Snapshotter._finalizer.attach(snapshotter, snapshotter._suffix);
Snapshotter._finalizer.attach(snapshotter, snapshotter._suffix, detach: snapshotter);
return snapshotter;
}

Expand Down