Fix Escape key mapping and add tests in parse-hotkey.ts #7928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d add tests - Change 'Escape' and 'Esc' mapping from 'esc' to 'escape' for consistency - Add 'esc' key to keyNameMap for backward compatibility - Add comprehensive tests for Escape key handling
Member
|
Thanks! |
rtivital
pushed a commit
that referenced
this pull request
Jun 17, 2025
…tly in some browsers (#7928) * [@matine/hooks] parse-hotkey.ts escapeHotkey fix add test code * [@mantine/hooks] fix: update Escape key mapping in parse-hotkey.ts and add tests - Change 'Escape' and 'Esc' mapping from 'esc' to 'escape' for consistency - Add 'esc' key to keyNameMap for backward compatibility - Add comprehensive tests for Escape key handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed: #7923
This pull request addresses the following updates in
parse-hotkey.ts:keyNameMapfor backward compatibility.