Chore: make ESLint happy

Author: SukkaW

eslint.config.mjs

@@ -108,7 +108,8 @@ export default tseslint.config(
             '@typescript-eslint/switch-exhaustiveness-check': ['error', { allowDefaultCaseForExhaustiveSwitch: true, considerDefaultExhaustiveForUnions: true }],
             '@typescript-eslint/parameter-properties': ['warn', { prefer: 'parameter-property' }],
 
-            '@typescript-eslint/no-namespace': 'off'
+            '@typescript-eslint/no-namespace': 'off',
+            '@typescript-eslint/only-throw-error': ['error', { allowRethrowing: true, allowThrowingAny: true, allowThrowingUnknown: true }]
         }
     },
     {

package.json

@@ -82,7 +82,7 @@
     "svgo": "^3.0.2",
     "terser": "^5.21.0",
     "typescript": "^5.8.3",
-    "typescript-eslint": "^8.31.1",
+    "typescript-eslint": "^8.44.0",
     "uncss": "^0.17.3"
   },
   "peerDependencies": {

src/_modules/minifyCss.ts

@@ -21,17 +21,26 @@ const mod: HtmlnanoModule<CssnanoOptions> = {
             return tree;
         }
 
-        const promises: (Promise<void> | undefined)[] = [];
+        const promises: Promise<void>[] = [];
+
+        let p: Promise<void> | undefined;
+
         tree.walk((node) => {
         // Skip SRI, reasons are documented in "minifyJs" module
             if (node.attrs && 'integrity' in node.attrs) {
                 return node;
             }
 
             if (isStyleNode(node)) {
-                promises.push(processStyleNode(node, cssnanoOptions, cssnano, postcss));
+                p = processStyleNode(node, cssnanoOptions, cssnano, postcss);
+                if (p) {
+                    promises.push(p);
+                }
             } else if (node.attrs && node.attrs.style) {
-                promises.push(processStyleAttr(node, cssnanoOptions, cssnano, postcss));
+                p = processStyleAttr(node, cssnanoOptions, cssnano, postcss);
+                if (p) {
+                    promises.push(p);
+                }
             }
 
             return node;

src/_modules/minifyJs.ts

@@ -12,7 +12,10 @@ const mod: HtmlnanoModule<MinifyOptions> = {
 
         if (!terser) return tree;
 
-        const promises: (Promise<void> | void)[] = [];
+        const promises: Promise<void>[] = [];
+
+        let p: Promise<void> | undefined;
+
         tree.walk((node) => {
             const nodeAttrs = node.attrs || {};
 
@@ -35,7 +38,10 @@ const mod: HtmlnanoModule<MinifyOptions> = {
             if (node.tag && node.tag === 'script') {
                 const mimeType = nodeAttrs.type || 'text/javascript';
                 if (redundantScriptTypes.has(mimeType) || mimeType === 'module') {
-                    promises.push(processScriptNode(node, terserOptions, terser));
+                    p = processScriptNode(node, terserOptions, terser);
+                    if (p) {
+                        promises.push(p);
+                    }
                 }
             }
 

test/helpers.ts

@@ -1,4 +1,5 @@
-import { Expect, expect } from 'expect';
+import { expect } from 'expect';
+import type { Expect } from 'expect';
 import { isAmpBoilerplate, isComment, isConditionalComment, isStyleNode, extractCssFromStyleNode, optionalImport } from '../dist/helpers.mjs';
 
 describe('[helpers]', () => {