Merge pull request #149 from macbre/queries_not_using_index-handle-no-tables-used

queries_not_using_index | handle "No tables used"

Author: macbre

indexdigest/linters/linter_0019_queries_not_using_indices.py

@@ -20,6 +20,7 @@ def check_queries_not_using_indices(database, queries):
         if explain_row['Extra'] in [
                 'Impossible WHERE noticed after reading const tables',
                 'no matching row in const table',
+                'No tables used'
         ]:
             continue
 

indexdigest/test/linters/test_0019_queries_not_using_indices.py

@@ -12,9 +12,9 @@ def test_queries(self):
         reports = list(check_queries_not_using_indices(
             database=self.connection, queries=read_queries_from_log('0019-queries-not-using-indices-log')))
 
-        # print(reports)
+        print(list(map(str, reports)))
 
-        self.assertEqual(len(reports), 2)
+        self.assertEqual(len(reports), 3)
 
         self.assertEqual(str(reports[0]), '0019_queries_not_using_indices: "SELECT item_id FROM 0019_queries_not_using_indices..." query did not make use of any index')
         self.assertEqual(reports[0].table_name, '0019_queries_not_using_indices')
@@ -27,4 +27,9 @@ def test_queries(self):
         self.assertEqual(str(reports[1].context['explain_extra']), 'Using where')
         self.assertEqual(str(reports[1].context['explain_rows']), '3')
 
+        self.assertEqual(reports[2].table_name, '0019_queries_not_using_indices')
+        self.assertEqual(str(reports[2].context['query']), 'SELECT 1 AS one FROM dual WHERE exists ( SELECT item_id FROM 0019_queries_not_using_indices WHERE foo = "test" );')
+        self.assertEqual(str(reports[2].context['explain_extra']), 'Using where')
+        self.assertEqual(str(reports[2].context['explain_rows']), '3')
+
         # assert False

sql/0019-queries-not-using-indices-log

@@ -7,3 +7,7 @@ SELECT item_id FROM 0019_queries_not_using_indices WHERE foo = "test" OR item_id
 SELECT item_id FROM 0019_queries_not_using_indices WHERE foo = "test"
 -- no matching row in const table (#44)
 SELECT foo FROM 0019_queries_not_using_indices WHERE item_id = 5;
+-- #148: EXPLAINS' Extra says "No tables used"
+SELECT 1*1;
+SELECT 1 AS one FROM dual WHERE exists ( SELECT 1 FROM 0000_the_table WHERE item_id = 2 );
+SELECT 1 AS one FROM dual WHERE exists ( SELECT item_id FROM 0019_queries_not_using_indices WHERE foo = "test" );