Refactor host stats formatters to remove unused parameters and improve example formatting in README

Author: mre

README.md

@@ -455,14 +455,18 @@ Options:
 
           This limits how many requests can be sent simultaneously to the same host (domain/subdomain). This helps prevent overwhelming servers and getting rate-limited. Each host is handled independently.
 
-          Examples: --default-host-concurrency 5   # Conservative for slow APIs --default-host-concurrency 20  # Aggressive for fast APIs
+          Examples:
+          • --default-host-concurrency 5   # Conservative for slow APIs
+          • --default-host-concurrency 20  # Aggressive for fast APIs
 
       --default-request-interval <DEFAULT_REQUEST_INTERVAL>
           Minimum interval between requests to the same host (default: 100ms)
 
           Sets a baseline delay between consecutive requests to prevent hammering servers. The adaptive algorithm may increase this based on server responses (rate limits, errors).
 
-          Examples: --default-request-interval 50ms   # Fast for robust APIs\ --default-request-interval 1s     # Conservative for rate-limited APIs
+          Examples:
+          • --default-request-interval 50ms   # Fast for robust APIs
+          • --default-request-interval 1s     # Conservative for rate-limited APIs
 
   -T, --threads <THREADS>
           Number of threads to utilize. Defaults to number of cores available to the system

lychee-bin/src/client.rs

@@ -44,19 +44,20 @@ pub(crate) fn create(cfg: &Config, cookie_jar: Option<&Arc<CookieStoreMutex>>) -
     let rate_limit_config =
         RateLimitConfig::from_options(cfg.default_host_concurrency, cfg.default_request_interval);
     let cache_max_age = if cfg.cache { 3600 } else { 0 }; // 1 hour if caching enabled, disabled otherwise
-    let host_pool = match cookie_jar {
-        Some(cookie_jar) => HostPool::with_cookie_jar(
+    let host_pool = if let Some(cookie_jar) = cookie_jar {
+        HostPool::with_cookie_jar(
             rate_limit_config,
             cfg.hosts.clone(),
             cfg.max_concurrency,
             cache_max_age,
-            combined_headers,
+            combined_headers.clone(),
             cfg.max_redirects,
             Some(timeout),
             cfg.insecure,
             cookie_jar.clone(),
-        ),
-        None => HostPool::new(
+        )
+    } else {
+        HostPool::new(
             rate_limit_config,
             cfg.hosts.clone(),
             cfg.max_concurrency,
@@ -65,7 +66,7 @@ pub(crate) fn create(cfg: &Config, cookie_jar: Option<&Arc<CookieStoreMutex>>) -
             cfg.max_redirects,
             Some(timeout),
             cfg.insecure,
-        ),
+        )
     };
 
     ClientBuilder::builder()

lychee-bin/src/formatters/host_stats/compact.rs

@@ -5,7 +5,6 @@ use std::{
 };
 
 use crate::formatters::color::{DIM, NORMAL, color};
-use crate::options;
 use lychee_lib::ratelimit::HostStats;
 
 use super::HostStatsFormatter;
@@ -65,7 +64,7 @@ impl Display for CompactHostStats {
 pub(crate) struct Compact;
 
 impl Compact {
-    pub(crate) const fn new(_mode: options::OutputMode) -> Self {
+    pub(crate) const fn new() -> Self {
         Self
     }
 }

lychee-bin/src/formatters/host_stats/detailed.rs

@@ -4,7 +4,6 @@ use std::{
     fmt::{self, Display},
 };
 
-use crate::options;
 use lychee_lib::ratelimit::HostStats;
 
 use super::HostStatsFormatter;
@@ -35,7 +34,11 @@ impl Display for DetailedHostStats {
             )?;
 
             if stats.rate_limited > 0 {
-                writeln!(f, "  Rate limited: {}", stats.rate_limited)?;
+                writeln!(
+                    f,
+                    "  Rate limited: {} (429 Too Many Requests)",
+                    stats.rate_limited
+                )?;
             }
             if stats.client_errors > 0 {
                 writeln!(f, "  Client errors (4xx): {}", stats.client_errors)?;
@@ -70,7 +73,7 @@ impl Display for DetailedHostStats {
 pub(crate) struct Detailed;
 
 impl Detailed {
-    pub(crate) const fn new(_mode: options::OutputMode) -> Self {
+    pub(crate) const fn new() -> Self {
         Self
     }
 }

lychee-bin/src/formatters/mod.rs

@@ -33,11 +33,11 @@ pub(crate) fn get_stats_formatter(
 /// Create a host stats formatter based on the given format and mode options
 pub(crate) fn get_host_stats_formatter(
     format: &StatsFormat,
-    mode: &OutputMode,
+    _mode: &OutputMode,
 ) -> Box<dyn HostStatsFormatter> {
     match format {
-        StatsFormat::Compact | StatsFormat::Raw => Box::new(host_stats::Compact::new(mode.clone())), // Use compact for raw
-        StatsFormat::Detailed => Box::new(host_stats::Detailed::new(mode.clone())),
+        StatsFormat::Compact | StatsFormat::Raw => Box::new(host_stats::Compact::new()), // Use compact for raw
+        StatsFormat::Detailed => Box::new(host_stats::Detailed::new()),
         StatsFormat::Json => Box::new(host_stats::Json::new()),
         StatsFormat::Markdown => Box::new(host_stats::Markdown::new()),
     }

lychee-bin/src/options.rs

@@ -929,6 +929,7 @@ impl Config {
                 // Keys which are handled outside of fold_in
                 ..header,
                 ..github_token,
+                ..hosts,
 
                 // Keys with defaults to assign
                 accept: StatusCodeSelector::default(),
@@ -957,7 +958,6 @@ impl Config {
                 glob_ignore_case: false,
                 hidden: false,
                 host_stats: false,
-                hosts: HashMap::new(),
                 include: Vec::<String>::new(),
                 include_fragments: false,
                 include_mail: false,