Fix call to supernova::RecursiveSNARK::verify#951
Fix call to supernova::RecursiveSNARK::verify#951huitseeker merged 2 commits intolurk-lab:mainfrom mpenciak:arecibo#175_companion
supernova::RecursiveSNARK::verify#951Conversation
| z0: &[F], | ||
| zi: &[F], | ||
| last_circuit_idx: usize, | ||
| _last_circuit_idx: usize, |
There was a problem hiding this comment.
If this is no longer necessary, we should open an issue about it.
There was a problem hiding this comment.
I'd vote for removing the unused argument from the API, and fixing downstream (lurk-rs) as part of integration of this work. That could possibly be by adjusting #936.
There was a problem hiding this comment.
Whoops… I thought I was looking at an arecibo change.
There was a problem hiding this comment.
We should definitely remove rather than ignore vestigial arguments — unless I'm missing something.
There was a problem hiding this comment.
Parity with Nova, I guess…
There was a problem hiding this comment.
verify is an unified API now. We need to pass at least something, maybe PhantomData. We define the extra input for verify when implementing RecursiveSNARKTrait, which is currently usize for both Nova and SuperNova proofs.
|
AFAIC, this is a breakage fix PR, we can address the unused argument later. |
|
Yes, that's why I mentioned that we should at least open an issue for it |
4 participants
This is a companion PR to arecibo#175 which changes the
supernova::RecursiveSNARK::verifyinterface by removing its dependence oncircuit_index.TODO before merge:
Cargo.tomlchange