Default to using multi-threading 🚀 #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To increase performance with the default settings, default to using one thread per CPU. The user must explicitly opt out if they want single-threaded behavior. This indirectly solves a different issue: the only way to automatically peg the number of threads to the number of CPU's was to set `--worker 0 --threads 0` even though the `worker` argument had been deprecated. Fixes lotabout#18
kesyog
force-pushed
the
default-multithreading
branch
from
0df65f1 to
5ecd8eb
Compare
kesyog
changed the title
Author
|
@lotabout ping. I'd love to get this merged if you don't see any major issues with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase performance with the default settings, default to using multi-threading, specifically one
thread per CPU. The user must explicitly opt out if they want
single-threaded behavior, the previous default.
This indirectly solves a different issue: the only way to automatically
peg the number of threads to the number of CPU's was to set
--worker 0 --threads 0even though theworkerargument had beendeprecated.
Fixes #18