Support standalone adapters #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport-standalone-adapters
olleolleolle
approved these changes
Mar 10, 2019
Member
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
This PR helps authors of external adapters a lot!
Member
|
Great work enabling Faraday to live its best life 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes a spec support file that external adapter gems can require in order to run all the relevant
shared_examplesto test an adapter.You can see this tested (against this branch) here: lostisland/faraday-http#1