Add HTTP.rb adapter #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technoweenie
approved these changes
Mar 8, 2019
Member
technoweenie
left a comment
technoweenie
left a comment
There was a problem hiding this comment.
Some small issues, but this looks solid.
Co-Authored-By: iMacTia <[email protected]>
Register the adapter under symbol :http
olleolleolle
reviewed
Mar 8, 2019
faraday-http.gemspec
Outdated
| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | ||
| spec.require_paths = ['lib'] | ||
|
|
||
| # spec.add_dependency 'faraday', '~> 1.0' |
Member
There was a problem hiding this comment.
Suggested change
| # spec.add_dependency 'faraday', '~> 1.0' |
olleolleolle
approved these changes
Mar 8, 2019
Member
Author
|
Just waiting for lostisland/faraday#941 to be merged before merging this in, will need to change the |
Member
|
@iMacTia That branch is now merged, this PR is ready for its next step: Gemfile fix. |
Member
Author
|
Thanks! Will try to have a look today otherwise tomorrow will be done 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an adapter for HTTP - The Gem! a.k.a http.rb
Based on the work from @PandaWhisperer in PandaWhisperer/faraday#1