add option to sorting message by a locale's order#703
Merged
Conversation
arnonrdp
approved these changes
Jan 25, 2022
|
Is there anything that can be done to move this along? Would really love to be able to use this feature. |
Contributor
Author
|
I don't know. Nothing has been committed to this project since October. And an issue discussing the state of the project (#694) was closed by the opener because maintenance was promised to happen in December and then the maintainers disappeared. |
Contributor
|
Maybe, it is better to work on a fork: openscript-ch#1 |
terales
approved these changes
Aug 27, 2023
huacnlee
pushed a commit
to huacnlee/i18n-ally
that referenced
this pull request
Aug 28, 2023
) * add option to sorting message by a locale's order Fixes lokalise#702 * Empty commit to trigger CI --------- Co-authored-by: Alex Terehov <terales@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i18n Ally uses a binary sort when it sorts keys. This is unexpected ("O" is sorted before "o") and doesn't take differences in how languages sort things into account.
This change adds two config settings
sortCompareandsortLocale.sortCompareisbinarywhich is the current behavioursortComparetolocaleand setsortLocaletoenand keys will be ordered according to English rules for sorting text.sortComparetolocaleand leavesortLocaleunspecified and each messages file will be sorted according to its own locale (e.g.en/common.jsonwill be sorted using English order, whilees/common.jsonwill be sorted according to Spanish order).Fixes #702