-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
๐ style: update SiliconCloud reasoning models #9287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ style: update SiliconCloud reasoning models #9287
Conversation
|
@AnotiaWang is attempting to deploy a commit to the LobeHub Community Team on Vercel. A member of the Team first needs to authorize it. |
|
๐ @AnotiaWang Thank you for raising your pull request and contributing to our Community |
Reviewer's GuideUpdates SiliconCloud model configurations to support reasoning toggles and budget parameters in model definitions, and refactors the runtime provider to dynamically apply and clamp thinking settings based on model patterns. Class diagram for updated SiliconCloud model configurationclassDiagram
class AIChatModelCard {
releasedAt: string
settings: object
type: string
}
class Settings {
extendParams: string[]
}
AIChatModelCard --> Settings : has
Settings : extendParams = ["enableReasoning", "reasoningBudgetToken"]
Class diagram for SiliconCloud runtime provider changesclassDiagram
class LobeSiliconCloudAI {
createOpenAICompatibleRuntime()
}
LobeSiliconCloudAI : - thinkingBudget
LobeSiliconCloudAI : - hybridThinkingModels
LobeSiliconCloudAI : + enable_thinking
LobeSiliconCloudAI : + thinking_budget
LobeSiliconCloudAI : + max_tokens
LobeSiliconCloudAI : + model
Flow diagram for dynamic thinking settings in SiliconCloud runtimeflowchart TD
A["Input: model, thinking, max_tokens, rest"] --> B["Determine thinkingBudget"]
B --> C["Create result object with rest, max_tokens, model"]
C --> D{"Is thinking defined?"}
D -- Yes --> E["Check if model matches hybridThinkingModels"]
E -- Yes --> F["Set enable_thinking based on thinking.type"]
D -- Yes --> G["If thinkingBudget defined, clamp and set thinking_budget"]
D -- No --> H["Return result"]
F --> G
G --> H
D -- No --> H
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
TestGru AssignmentSummary
Tip You can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `packages/model-runtime/src/providers/siliconcloud/index.ts:61-62` </location>
<code_context>
+ /DeepSeek-V3\.1/,
+ /Hunyuan-A13B-Instruct/,
+ ];
+ if (hybridThinkingModels.some((regexp) => regexp.test(model))) {
+ result.enable_thinking = thinking.type === 'enabled';
+ }
+ if (typeof thinkingBudget !== 'undefined') {
</code_context>
<issue_to_address>
**issue:** Potential case sensitivity issue in model matching.
Consider normalizing the model string or using case-insensitive regexes to prevent mismatches due to case sensitivity.
</issue_to_address>
### Comment 2
<location> `packages/model-bank/src/aiModels/siliconcloud.ts:87-88` </location>
<code_context>
],
},
releasedAt: '2025-08-20',
+ settings: {
+ extendParams: ['reasoningBudgetToken'],
+ },
type: 'chat',
</code_context>
<issue_to_address>
**question:** Inconsistent extendParams for similar models.
If the difference in extendParams is intentional, please document the reasoning to help future maintainers.
</issue_to_address>Help me be more useful! Please click ๐ or ๐ on each comment and I'll use the feedback to improve your reviews.
| if (hybridThinkingModels.some((regexp) => regexp.test(model))) { | ||
| result.enable_thinking = thinking.type === 'enabled'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Potential case sensitivity issue in model matching.
Consider normalizing the model string or using case-insensitive regexes to prevent mismatches due to case sensitivity.
| settings: { | ||
| extendParams: ['reasoningBudgetToken'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Inconsistent extendParams for similar models.
If the difference in extendParams is intentional, please document the reasoning to help future maintainers.
Codecov Reportโ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9287 +/- ##
==========================================
- Coverage 79.81% 79.80% -0.01%
==========================================
Files 819 819
Lines 52930 52936 +6
Branches 5482 5482
==========================================
Hits 42246 42246
- Misses 10684 10690 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
๐ New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
โค๏ธ Great PR @AnotiaWang โค๏ธ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.129.1](v1.129.0...v1.129.1) <sup>Released on **2025-09-16**</sup> #### โป Code Refactoring - **misc**: Improve db sql performance. #### ๐ Styles - **misc**: Update SiliconCloud reasoning models. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Improve db sql performance, closes [#9283](#9283) ([cee555a](cee555a)) #### Styles * **misc**: Update SiliconCloud reasoning models, closes [#9287](#9287) ([b47bb5b](b47bb5b)) </details> <div align="right"> [](#readme-top) </div>
|
๐ This PR is included in version 1.129.1 ๐ The release is available on: Your semantic-release bot ๐ฆ๐ |
## [Version 1.127.0](v1.126.0...v1.127.0) <sup>Released on **2025-09-17**</sup> #### โป Code Refactoring - **misc**: Improve db sql performance, refactor message proccesser to the context engine. #### โจ Features - **misc**: Support Vercel AI Gateway provider. #### ๐ Bug Fixes - **misc**: Add qwen provider support for image-edit model, fix azure ai runtime error, fix open chat page with float link modal, Google stream error unable to abort request, improve db migrations sql. #### ๐ Styles - **misc**: Enable toggling search on/off via search button click & historyCount button, fix discover plugin link, improve error handle with agent config, support `.doc` file parse, update i18n, update i18n, update i18n, Update model configs, update SiliconCloud reasoning models. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Improve db sql performance, closes [lobehub#9283](https://github.com/jaworldwideorg/OneJA-Bot/issues/9283) ([cee555a](cee555a)) * **misc**: Refactor message proccesser to the context engine, closes [lobehub#9230](https://github.com/jaworldwideorg/OneJA-Bot/issues/9230) ([dacfffd](dacfffd)) #### What's improved * **misc**: Support Vercel AI Gateway provider, closes [lobehub#8883](https://github.com/jaworldwideorg/OneJA-Bot/issues/8883) ([5a4b0fd](5a4b0fd)) #### What's fixed * **misc**: Add qwen provider support for image-edit model, closes [lobehub#9277](https://github.com/jaworldwideorg/OneJA-Bot/issues/9277) [lobehub#9184](https://github.com/jaworldwideorg/OneJA-Bot/issues/9184) ([e137b33](e137b33)) * **misc**: Fix azure ai runtime error, closes [lobehub#9276](https://github.com/jaworldwideorg/OneJA-Bot/issues/9276) ([c21c14e](c21c14e)) * **misc**: Fix open chat page with float link modal, closes [lobehub#9235](https://github.com/jaworldwideorg/OneJA-Bot/issues/9235) ([2c677e5](2c677e5)) * **misc**: Google stream error unable to abort request, closes [lobehub#9180](https://github.com/jaworldwideorg/OneJA-Bot/issues/9180) ([78eaead](78eaead)) * **misc**: Improve db migrations sql, closes [lobehub#9295](https://github.com/jaworldwideorg/OneJA-Bot/issues/9295) ([96ff5aa](96ff5aa)) #### Styles * **misc**: Enable toggling search on/off via search button click & historyCount button, closes [lobehub#9173](https://github.com/jaworldwideorg/OneJA-Bot/issues/9173) ([240c7b7](240c7b7)) * **misc**: Fix discover plugin link, closes [lobehub#9240](https://github.com/jaworldwideorg/OneJA-Bot/issues/9240) ([cfb2246](cfb2246)) * **misc**: Improve error handle with agent config, closes [lobehub#9263](https://github.com/jaworldwideorg/OneJA-Bot/issues/9263) ([6656217](6656217)) * **misc**: Support `.doc` file parse, closes [lobehub#8182](https://github.com/jaworldwideorg/OneJA-Bot/issues/8182) ([ed42753](ed42753)) * **misc**: Update i18n, closes [lobehub#9294](https://github.com/jaworldwideorg/OneJA-Bot/issues/9294) ([c018f3d](c018f3d)) * **misc**: Update i18n, closes [lobehub#9243](https://github.com/jaworldwideorg/OneJA-Bot/issues/9243) ([04764ad](04764ad)) * **misc**: Update i18n, closes [lobehub#9237](https://github.com/jaworldwideorg/OneJA-Bot/issues/9237) ([642dc3b](642dc3b)) * **misc**: Update model configs, closes [lobehub#9170](https://github.com/jaworldwideorg/OneJA-Bot/issues/9170) ([f89b730](f89b730)) * **misc**: Update SiliconCloud reasoning models, closes [lobehub#9287](https://github.com/jaworldwideorg/OneJA-Bot/issues/9287) ([b47bb5b](b47bb5b)) </details> <div align="right"> [](#readme-top) </div>
๐ป ๅๆด็ฑปๅ | Change Type
๐ ๅๆด่ฏดๆ | Description of Change
ๆน่ฟ SiliconCloud ็ model-runtime ๅฎ็ฐ๏ผๆฏๆ้ ็ฝฎๆดๅคๆจกๅ็ๆ่ๅผๅ ณๅ thinking budgetใ
ๆฏๆๅฟซๆ ขๆ่็ๆจกๅ๏ผ

ไป ๆฏๆๆ ขๆ่็ๆจกๅ๏ผ

๐ ่กฅๅ ไฟกๆฏ | Additional Information
Summary by Sourcery
Enable advanced reasoning controls for SiliconCloud models by exposing reasoningBudgetToken and enableReasoning settings in model definitions and updating the runtime provider to apply and validate these parameters dynamically.
New Features:
Enhancements: