Address review comments

Author: kovdan01

lld/ELF/Arch/AArch64.cpp

@@ -433,7 +433,7 @@ void AArch64::relocate(uint8_t *loc, const Relocation &rel,
     // .relr.auth.dyn to .rela.dyn, and the addend write is not needed.
     //
     // If val fits in 32 bits, we have two potential scenarios:
-    // * True RELR: Write the 32-bit `val`
+    // * True RELR: Write the 32-bit `val`.
     // * RELA: Even if the value now fits in 32 bits, it might have been
     //   converted from RELR during an iteration in
     //   finalizeAddressDependentContent(). Writing the value is harmless

lld/ELF/SyntheticSections.h

@@ -549,8 +549,8 @@ class RelocationBaseSection : public SyntheticSection {
     return SyntheticSection::classof(d) &&
            (d->type == llvm::ELF::SHT_RELA || d->type == llvm::ELF::SHT_REL ||
             d->type == llvm::ELF::SHT_RELR ||
-            (config->emachine == llvm::ELF::EM_AARCH64 &&
-             d->type == llvm::ELF::SHT_AARCH64_AUTH_RELR));
+            (d->type == llvm::ELF::SHT_AARCH64_AUTH_RELR &&
+             config->emachine == llvm::ELF::EM_AARCH64));
   }
   int32_t dynamicTag, sizeDynamicTag;
   SmallVector<DynamicReloc, 0> relocs;

lld/ELF/Writer.cpp

@@ -1459,7 +1459,7 @@ template <class ELFT> void Writer<ELFT>::finalizeAddressDependentContent() {
       // during RelocationScanner::processAux, but the target VA for some of
       // them might be wider than 32 bits. We can only know the final VA at this
       // point, so move relocations with large values from .relr.auth.dyn to
-      // .rela.dyn.
+      // .rela.dyn. See also AArch64::relocate.
       if (part.relrAuthDyn) {
         auto it = llvm::remove_if(
             part.relrAuthDyn->relocs, [&part](const RelativeReloc &elem) {
@@ -1470,7 +1470,6 @@ template <class ELFT> void Writer<ELFT>::finalizeAddressDependentContent() {
                                       reloc.offset,
                                       DynamicReloc::AddendOnlyWithTargetVA,
                                       *reloc.sym, reloc.addend, R_ABS});
-              // See also AArch64::relocate
               return true;
             });
         changed |= (it != part.relrAuthDyn->relocs.end());