Skip to content

Commit e592c2d

Browse files
shiltianshiltian
committed
Revert "[Attributor] Enable AAAddressSpace for OpenMPOpt (#65544)"
This reverts commit e91e3cf because AMD BB is not happy with it.
1 parent b5fc4a8 commit e592c2d

6 files changed

Lines changed: 26 additions & 30 deletions

File tree

‎llvm/lib/Transforms/IPO/OpenMPOpt.cpp‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5437,8 +5437,6 @@ void OpenMPOpt::registerAAsForFunction(Attributor &A, const Function &F) {
54375437
bool UsedAssumedInformation = false;
54385438
A.getAssumedSimplified(IRPosition::value(*LI), /* AA */ nullptr,
54395439
UsedAssumedInformation, AA::Interprocedural);
5440-
A.getOrCreateAAFor<AAAddressSpace>(
5441-
IRPosition::value(*LI->getPointerOperand()));
54425440
continue;
54435441
}
54445442
if (auto *CI = dyn_cast<CallBase>(&I)) {
@@ -5448,8 +5446,6 @@ void OpenMPOpt::registerAAsForFunction(Attributor &A, const Function &F) {
54485446
}
54495447
if (auto *SI = dyn_cast<StoreInst>(&I)) {
54505448
A.getOrCreateAAFor<AAIsDead>(IRPosition::value(*SI));
5451-
A.getOrCreateAAFor<AAAddressSpace>(
5452-
IRPosition::value(*SI->getPointerOperand()));
54535449
continue;
54545450
}
54555451
if (auto *FI = dyn_cast<FenceInst>(&I)) {

‎llvm/test/Transforms/Attributor/reduced/openmp_opt_constant_type_crash.ll‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ cond.end: ; preds = %cond.true, %entry
116116
; CHECK-LABEL: define {{[^@]+}}@_ZN6Kokkos4Impl14SubviewExtentsILj2ELj1EE3setIJLm0ELm0EEJiEEEbjjRKNS0_13ViewDimensionIJXspT_EEEENS0_5ALL_tEDpT0_.internalized
117117
; CHECK-SAME: (ptr nocapture writeonly [[THIS:%.*]]) #[[ATTR1]] {
118118
; CHECK-NEXT: entry:
119-
; CHECK-NEXT: [[TMP0:%.*]] = addrspacecast ptr [[THIS]] to ptr addrspace(5)
120119
; CHECK-NEXT: ret i1 false
121120
;
122121
;

‎llvm/test/Transforms/OpenMP/barrier_removal.ll‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -267,9 +267,10 @@ define void @neg_empty_2() "kernel" {
267267
define void @pos_constant_loads() "kernel" {
268268
; CHECK-LABEL: define {{[^@]+}}@pos_constant_loads
269269
; CHECK-SAME: () #[[ATTR4]] {
270-
; CHECK-NEXT: [[ARG:%.*]] = load ptr addrspace(4), ptr addrspace(4) @GPtr4, align 8
271-
; CHECK-NEXT: [[B:%.*]] = load i32, ptr addrspace(4) @GC2, align 4
272-
; CHECK-NEXT: [[C:%.*]] = load i32, ptr addrspace(4) [[ARG]], align 4
270+
; CHECK-NEXT: [[ARG:%.*]] = load ptr addrspace(4), ptr addrspacecast (ptr addrspace(4) @GPtr4 to ptr), align 8
271+
; CHECK-NEXT: [[B:%.*]] = load i32, ptr addrspacecast (ptr addrspace(4) @GC2 to ptr), align 4
272+
; CHECK-NEXT: [[ARGC:%.*]] = addrspacecast ptr addrspace(4) [[ARG]] to ptr
273+
; CHECK-NEXT: [[C:%.*]] = load i32, ptr [[ARGC]], align 4
273274
; CHECK-NEXT: [[D:%.*]] = add i32 42, [[B]]
274275
; CHECK-NEXT: [[E:%.*]] = add i32 [[D]], [[C]]
275276
; CHECK-NEXT: call void @useI32(i32 [[E]])
@@ -300,7 +301,7 @@ define void @neg_loads() "kernel" {
300301
; CHECK-NEXT: [[ARG:%.*]] = load ptr, ptr @GPtr, align 8
301302
; CHECK-NEXT: [[A:%.*]] = load i32, ptr @G, align 4
302303
; CHECK-NEXT: call void @aligned_barrier()
303-
; CHECK-NEXT: [[B:%.*]] = load i32, ptr addrspace(3) @GS, align 4
304+
; CHECK-NEXT: [[B:%.*]] = load i32, ptr addrspacecast (ptr addrspace(3) @GS to ptr), align 4
304305
; CHECK-NEXT: call void @aligned_barrier()
305306
; CHECK-NEXT: [[C:%.*]] = load i32, ptr [[ARG]], align 4
306307
; CHECK-NEXT: call void @aligned_barrier()
@@ -332,8 +333,9 @@ define void @pos_priv_mem() "kernel" {
332333
; CHECK-NEXT: [[LOC:%.*]] = alloca i32, align 4
333334
; CHECK-NEXT: [[A:%.*]] = load i32, ptr @PG1, align 4
334335
; CHECK-NEXT: store i32 [[A]], ptr [[LOC]], align 4
335-
; CHECK-NEXT: [[B:%.*]] = load i32, ptr addrspace(5) @PG2, align 4
336-
; CHECK-NEXT: store i32 [[B]], ptr addrspace(5) [[ARG]], align 4
336+
; CHECK-NEXT: [[B:%.*]] = load i32, ptr addrspacecast (ptr addrspace(5) @PG2 to ptr), align 4
337+
; CHECK-NEXT: [[ARGC:%.*]] = addrspacecast ptr addrspace(5) [[ARG]] to ptr
338+
; CHECK-NEXT: store i32 [[B]], ptr [[ARGC]], align 4
337339
; CHECK-NEXT: [[V:%.*]] = load i32, ptr [[LOC]], align 4
338340
; CHECK-NEXT: store i32 [[V]], ptr @PG1, align 4
339341
; CHECK-NEXT: ret void
@@ -366,7 +368,7 @@ define void @neg_mem() "kernel" {
366368
; CHECK-NEXT: store i32 [[A]], ptr [[ARG]], align 4
367369
; CHECK-NEXT: fence release
368370
; CHECK-NEXT: call void @aligned_barrier()
369-
; CHECK-NEXT: [[B:%.*]] = load i32, ptr addrspace(1) @G2, align 4
371+
; CHECK-NEXT: [[B:%.*]] = load i32, ptr addrspacecast (ptr addrspace(1) @G2 to ptr), align 4
370372
; CHECK-NEXT: store i32 [[B]], ptr @G1, align 4
371373
; CHECK-NEXT: fence acquire
372374
; CHECK-NEXT: ret void

‎llvm/test/Transforms/OpenMP/heap-to-shared-missing-declarations.ll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ define internal void @func() {
2222
; CHECK-LABEL: define {{[^@]+}}@func
2323
; CHECK-SAME: () #[[ATTR1]] {
2424
; CHECK-NEXT: bb:
25-
; CHECK-NEXT: [[I:%.*]] = load ptr, ptr addrspace(5) null, align 4294967296
25+
; CHECK-NEXT: [[I:%.*]] = load ptr, ptr null, align 4294967296
2626
; CHECK-NEXT: store i64 0, ptr [[I]], align 8
2727
; CHECK-NEXT: ret void
2828
;

‎llvm/test/Transforms/OpenMP/nested_parallelism.ll‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ define weak_odr protected void @__omp_offloading_10302_bd7e0_main_l13(i64 nounde
6060
; CHECK-NEXT: br i1 [[TMP3]], label [[REGION_GUARDED_I:%.*]], label [[_Z3FOOI_INTERNALIZED_EXIT:%.*]]
6161
; CHECK: region.guarded.i:
6262
; CHECK-NEXT: [[I_ADDR_SROA_0_0_EXTRACT_TRUNC:%.*]] = trunc i64 [[I:%.*]] to i32
63-
; CHECK-NEXT: store i32 [[I_ADDR_SROA_0_0_EXTRACT_TRUNC]], ptr addrspace(3) @i_shared, align 16
63+
; CHECK-NEXT: store i32 [[I_ADDR_SROA_0_0_EXTRACT_TRUNC]], ptr addrspacecast (ptr addrspace(3) @i_shared to ptr), align 16
6464
; CHECK-NEXT: br label [[_Z3FOOI_INTERNALIZED_EXIT]]
6565
; CHECK: _Z3fooi.internalized.exit:
6666
; CHECK-NEXT: tail call void @__kmpc_barrier_simple_spmd(ptr nonnull @[[GLOB1]], i32 [[TMP2]]) #[[ATTR2]]
67-
; CHECK-NEXT: store ptr addrspace(3) @i_shared, ptr [[CAPTURED_VARS_ADDRS_I]], align 8
67+
; CHECK-NEXT: store ptr addrspacecast (ptr addrspace(3) @i_shared to ptr), ptr [[CAPTURED_VARS_ADDRS_I]], align 8
6868
; CHECK-NEXT: call void @__kmpc_parallel_51(ptr nonnull @[[GLOB1]], i32 [[TMP1]], i32 1, i32 -1, i32 -1, ptr nonnull @__omp_outlined__, ptr nonnull @__omp_outlined___wrapper, ptr nonnull [[CAPTURED_VARS_ADDRS_I]], i64 1)
6969
; CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr nonnull [[CAPTURED_VARS_ADDRS_I]])
7070
; CHECK-NEXT: call void @__kmpc_target_deinit()
@@ -140,8 +140,8 @@ define weak_odr protected void @__omp_offloading_10302_bd7e0_main_l16(i64 nounde
140140
; CHECK-NEXT: [[I_ADDR_SROA_0_0_EXTRACT_TRUNC:%.*]] = trunc i64 [[I:%.*]] to i32
141141
; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 8, ptr nonnull [[CAPTURED_VARS_ADDRS_I]])
142142
; CHECK-NEXT: [[TMP1:%.*]] = tail call i32 @__kmpc_global_thread_num(ptr nonnull @[[GLOB1]]) #[[ATTR2]]
143-
; CHECK-NEXT: store i32 [[I_ADDR_SROA_0_0_EXTRACT_TRUNC]], ptr addrspace(3) @i.i_shared, align 16
144-
; CHECK-NEXT: store ptr addrspace(3) @i.i_shared, ptr [[CAPTURED_VARS_ADDRS_I]], align 8
143+
; CHECK-NEXT: store i32 [[I_ADDR_SROA_0_0_EXTRACT_TRUNC]], ptr addrspacecast (ptr addrspace(3) @i.i_shared to ptr), align 16
144+
; CHECK-NEXT: store ptr addrspacecast (ptr addrspace(3) @i.i_shared to ptr), ptr [[CAPTURED_VARS_ADDRS_I]], align 8
145145
; CHECK-NEXT: call void @__kmpc_parallel_51(ptr nonnull @[[GLOB1]], i32 [[TMP1]], i32 1, i32 -1, i32 -1, ptr nonnull @__omp_outlined__1, ptr nonnull @__omp_outlined__1_wrapper, ptr nonnull [[CAPTURED_VARS_ADDRS_I]], i64 1)
146146
; CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr nonnull [[CAPTURED_VARS_ADDRS_I]])
147147
; CHECK-NEXT: call void @__kmpc_target_deinit()

‎llvm/test/Transforms/OpenMP/spmdization_kernel_env_dep.ll‎

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -27,22 +27,21 @@ define i32 @fputs() {
2727
define internal i32 @__kmpc_target_init(ptr %0) {
2828
; AMDGPU-LABEL: define {{[^@]+}}@__kmpc_target_init
2929
; AMDGPU-SAME: (ptr [[TMP0:%.*]]) #[[ATTR1:[0-9]+]] {
30-
; AMDGPU-NEXT: [[TMP2:%.*]] = addrspacecast ptr getelementptr (i8, ptr addrspacecast (ptr addrspace(1) @__omp_offloading_10302_b20a40e_main_l4_kernel_environment to ptr), i64 2) to ptr addrspace(1)
31-
; AMDGPU-NEXT: [[TMP3:%.*]] = load i8, ptr addrspace(1) [[TMP2]], align 2
32-
; AMDGPU-NEXT: [[TMP4:%.*]] = and i8 [[TMP3]], 2
33-
; AMDGPU-NEXT: [[TMP5:%.*]] = icmp ne i8 [[TMP4]], 0
34-
; AMDGPU-NEXT: [[TMP6:%.*]] = tail call i32 @llvm.amdgcn.workitem.id.x() #[[ATTR3:[0-9]+]]
35-
; AMDGPU-NEXT: [[TMP7:%.*]] = icmp eq i32 [[TMP6]], 0
36-
; AMDGPU-NEXT: [[OR_COND:%.*]] = select i1 [[TMP5]], i1 [[TMP7]], i1 false
37-
; AMDGPU-NEXT: br i1 [[OR_COND]], label [[TMP8:%.*]], label [[TMP9:%.*]]
38-
; AMDGPU: 8:
30+
; AMDGPU-NEXT: [[TMP2:%.*]] = load i8, ptr getelementptr (i8, ptr addrspacecast (ptr addrspace(1) @__omp_offloading_10302_b20a40e_main_l4_kernel_environment to ptr), i64 2), align 2
31+
; AMDGPU-NEXT: [[TMP3:%.*]] = and i8 [[TMP2]], 2
32+
; AMDGPU-NEXT: [[TMP4:%.*]] = icmp ne i8 [[TMP3]], 0
33+
; AMDGPU-NEXT: [[TMP5:%.*]] = tail call i32 @llvm.amdgcn.workitem.id.x() #[[ATTR3:[0-9]+]]
34+
; AMDGPU-NEXT: [[TMP6:%.*]] = icmp eq i32 [[TMP5]], 0
35+
; AMDGPU-NEXT: [[OR_COND:%.*]] = select i1 [[TMP4]], i1 [[TMP6]], i1 false
36+
; AMDGPU-NEXT: br i1 [[OR_COND]], label [[TMP7:%.*]], label [[TMP8:%.*]]
37+
; AMDGPU: 7:
3938
; AMDGPU-NEXT: store i8 0, ptr addrspace(3) null, align 2147483648
40-
; AMDGPU-NEXT: br label [[TMP9]]
39+
; AMDGPU-NEXT: br label [[TMP8]]
40+
; AMDGPU: 8:
41+
; AMDGPU-NEXT: br label [[TMP10:%.*]]
4142
; AMDGPU: 9:
42-
; AMDGPU-NEXT: br label [[TMP11:%.*]]
43-
; AMDGPU: 10:
4443
; AMDGPU-NEXT: unreachable
45-
; AMDGPU: 11:
44+
; AMDGPU: 10:
4645
; AMDGPU-NEXT: ret i32 0
4746
;
4847
%2 = getelementptr %struct.ConfigurationEnvironmentTy.8, ptr %0, i64 0, i32 2

0 commit comments

Comments
 (0)